Use Wasp main in CI
#588
Use Wasp main in CI
#588
Conversation
cprecioso
force-pushed
the
cprecioso/use-wasp-main
branch
from
205f495 to
9a2e8ae
Compare
cprecioso
force-pushed
the
cprecioso/use-wasp-main
branch
from
ac5c0ab to
02ad5f3
Compare
FranjoMindek
left a comment
FranjoMindek
left a comment
There was a problem hiding this comment.
Hey, everything seems fine, but I'm just curious "@testing-library/react" package added to the devDeps of the template.
How come?
|
|
||
| # Just a wrapper to always use the latest Wasp CLI from main branch. | ||
|
|
||
| npx -y https://pkg.pr.new/@wasp.sh/wasp-cli@main "$@" |
There was a problem hiding this comment.
This is actually a really nice addition for external contributors.
There was a problem hiding this comment.
Do we use a different name to denote it's a development version or no?
waspd -> wasp development?
There was a problem hiding this comment.
Mmm no strong opinion. I thought a bit and couldn't find any name that I like, so I'll stay with just wasp.
template/app/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@faker-js/faker": "8.3.1", | ||
| "@testing-library/react": "^16.3.1", |
There was a problem hiding this comment.
leftover from a previous version of the PR
.github/workflows/e2e-tests.yml
Outdated
| # If you're copying this workflow to your own project, you can remove this step: | ||
| - name: Install latest development Wasp | ||
| if: env.WASP_VERSION == 'main' | ||
| run: | ||
| # Installs the latest published build of the CLI from the `main` branch. | ||
| npm i -g https://pkg.pr.new/@wasp.sh/wasp-cli@main |
There was a problem hiding this comment.
Maybe?
| # If you're copying this workflow to your own project, you can remove this step: | |
| - name: Install latest development Wasp | |
| if: env.WASP_VERSION == 'main' | |
| run: | |
| # Installs the latest published build of the CLI from the `main` branch. | |
| npm i -g https://pkg.pr.new/@wasp.sh/wasp-cli@main | |
| # If you're copying this workflow to your own project, you can remove this step. | |
| # Installs the latest published build of the CLI from the `main` branch. | |
| - name: Install latest development Wasp | |
| if: env.WASP_VERSION == 'main' | |
| run: npm i -g https://pkg.pr.new/@wasp.sh/wasp-cli@main |
There was a problem hiding this comment.
I separated it so that people don't think that they need to understand the second part in order to act on the first one.
I moved the comment one line up so the run property looks less weird.
There was a problem hiding this comment.
Yep, this little change makes it easier to read.
I like it.
|
@FranjoMindek ready for re-review |
FranjoMindek
left a comment
FranjoMindek
left a comment
There was a problem hiding this comment.
All seems fine now. Approving!
Description
open-saasdevelopment version is out of sync withwaspdevelopment version wasp#3073From now on, OpenSaaS is developed with the
mainversion of Wasp (instead of the released one). This is done to get feedback and CI testing of any incompatible changes as soon as possible.Contributor Checklist