docs update code info #899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
iisakkirotko
requested changes
Dec 6, 2024
Comment on lines
21
to
23
| dense, set_dense = solara.use_state(False) | ||
| outlined, set_outlined = solara.use_state(True) | ||
| text, set_text = solara.use_state(True) |
There was a problem hiding this comment.
Same here, replace use_state with use_reactive
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
cded5b2 to
32af76f
Compare
iisakkirotko
force-pushed
the
docs_update_code_info
branch
from
ef5a902 to
d790a19
Compare
iisakkirotko
requested changes
Dec 30, 2024
| solara.Checkbox(label="Show as text", value=text) | ||
| solara.Checkbox(label="Show outlined", value=outlined) | ||
| solara.Info( | ||
| f"This is solara.Info(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})", |
There was a problem hiding this comment.
Should also use .value here.
Suggested change
| f"This is solara.Info(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})", | |
| f"This is solara.Info(label='...', text={text.value}, dense={dense.value}, outlined={outlined.value}, icon={icon.value})", |
Comment on lines
32
to
35
| text=text, | ||
| dense=dense, | ||
| outlined=outlined, | ||
| icon=icon, |
There was a problem hiding this comment.
And here
Suggested change
| text=text, | |
| dense=dense, | |
| outlined=outlined, | |
| icon=icon, | |
| text=text.value, | |
| dense=dense.value, | |
| outlined=outlined.value, | |
| icon=icon.value, |
…olara into docs_update_code_info
iisakkirotko
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.