Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update code info #899

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

docs update code info #899

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2b892df
docs update code info
lizzy985 Dec 2, 2024
1ed5fbe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 2, 2024
35a857f
docs update code info
lizzy985 Dec 2, 2024
647fa44
docs update code info-2
lizzy985 Dec 29, 2024
45925ea
docs update code info-3
lizzy985 Dec 29, 2024
fba862a
docs update code info
lizzy985 Dec 2, 2024
d790a19
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 2, 2024
9d14ffe
docs_update_code_info_3
lizzy985 Jan 5, 2025
e09884c
Merge branch 'docs_update_code_info' of https://github.com/lizzy985/s…
lizzy985 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions solara/website/pages/documentation/components/status/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,19 @@ def Page():
dense, set_dense = solara.use_state(False)
outlined, set_outlined = solara.use_state(True)
text, set_text = solara.use_state(True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, replace use_state with use_reactive

with solara.VBox() as main:
with solara.GridFixed(4):
solara.Checkbox(label="Use icon", value=icon, on_value=set_icon)
solara.Checkbox(label="Show dense", value=dense, on_value=set_dense)
solara.Checkbox(label="Show as text", value=text, on_value=set_text)
solara.Checkbox(label="Show outlined", value=outlined, on_value=set_outlined)
solara.Info(
f"This is solara.Info(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
text=text,
dense=dense,
outlined=outlined,
icon=icon,
)
return main

with solara.GridFixed(4):
solara.Checkbox(label="Use icon", value=icon, on_value=set_icon)
solara.Checkbox(label="Show dense", value=dense, on_value=set_dense)
solara.Checkbox(label="Show as text", value=text, on_value=set_text)
solara.Checkbox(label="Show outlined", value=outlined, on_value=set_outlined)
solara.Info(
f"This is solara.Info(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also use .value here.

Suggested change
f"This is solara.Info(label='...', text={text}, dense={dense}, outlined={outlined}, icon={icon})",
f"This is solara.Info(label='...', text={text.value}, dense={dense.value}, outlined={outlined.value}, icon={icon.value})",

text=text,
dense=dense,
outlined=outlined,
icon=icon,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

Suggested change
text=text,
dense=dense,
outlined=outlined,
icon=icon,
text=text.value,
dense=dense.value,
outlined=outlined.value,
icon=icon.value,

)


__doc__ += apidoc(solara.Info.f) # type: ignore
Loading