fix: German localization - WPB-27847 - #5192
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are low-risk localization/casing adjustments, with only a minor formatting nit noted in the updated multiline ternary.
Pull request overview
This PR addresses WPB-27847 by correcting German localization issues in authentication and settings, and by removing runtime forced capitalization that was altering localized strings (notably affecting German word casing in participant selection titles).
Changes:
- Add missing German string for the “resend code after seconds” label in the authentication flow.
- Remove
.capitalizedusage for participant selection titles so localized casing is preserved. - Fix a German settings label to use the correct hyphenation (“Senden‑Taste”).
File summaries
| File | Description |
|---|---|
| WireAuthentication/Sources/WireAuthenticationUI/Resources/Localization/de.lproj/Localizable.strings | Adds missing German translation for the resend-code-with-wait-time label. |
| wire-ios/Wire-iOS/Sources/UserInterface/AddContacts/AddParticipantsViewModel.swift | Stops forcing capitalization on localized participant-selection titles (preserves German casing). |
| wire-ios/Wire-iOS/Sources/UserInterface/AddContacts/AddParticipantsViewController.swift | Stops forcing capitalization when setting the navigation bar title for this screen. |
| wire-ios/Wire-iOS/Resources/Localization/de.lproj/Localizable.strings | Fixes German hyphenation for the “send button” setting label. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results1 988 tests 1 961 ✅ 2m 46s ⏱️ Results for commit 5d0ba25. ♻️ This comment has been updated with latest results. Summary: workflow run #34340505966 |
Issue
Fix couple of german localization, see ticket:
Crowdin was already updated by Astrid
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: