Skip to content

fix: German localization - WPB-27847 - #5192

Open
netbe wants to merge 4 commits into
release/cycle-4.16from
fix/localization-german-WPB-27847
Open

fix: German localization - WPB-27847#5192
netbe wants to merge 4 commits into
release/cycle-4.16from
fix/localization-german-WPB-27847

Conversation

@netbe

@netbe netbe commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator
BugWPB-27847 [iOS] [Localization] German labels contain spelling errors or remain untranslated when navigating settings, group creation, and 2FA by users

Issue

Fix couple of german localization, see ticket:

  • Add hyphen: “Senden Taste” change to “Senden-Taste”
  • Removed forced capitalization: “Teilnehmer Auswählen” change to “Teilnehmer auswählen”
  • Ported missing translation to release branch: “Resend Code”use “Code erneut senden” (exists in crowdin)

Crowdin was already updated by Astrid

Testing

Simulator Screenshot - iPhone 14 - 18 5 - 2026-09-07 at 17 15 10 Simulator Screenshot - iPhone 14 - 18 5 - 2026-09-07 at 17 14 57

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are low-risk localization/casing adjustments, with only a minor formatting nit noted in the updated multiline ternary.

Pull request overview

This PR addresses WPB-27847 by correcting German localization issues in authentication and settings, and by removing runtime forced capitalization that was altering localized strings (notably affecting German word casing in participant selection titles).

Changes:

  • Add missing German string for the “resend code after seconds” label in the authentication flow.
  • Remove .capitalized usage for participant selection titles so localized casing is preserved.
  • Fix a German settings label to use the correct hyphenation (“Senden‑Taste”).
File summaries
File Description
WireAuthentication/Sources/WireAuthenticationUI/Resources/Localization/de.lproj/Localizable.strings Adds missing German translation for the resend-code-with-wait-time label.
wire-ios/Wire-iOS/Sources/UserInterface/AddContacts/AddParticipantsViewModel.swift Stops forcing capitalization on localized participant-selection titles (preserves German casing).
wire-ios/Wire-iOS/Sources/UserInterface/AddContacts/AddParticipantsViewController.swift Stops forcing capitalization when setting the navigation bar title for this screen.
wire-ios/Wire-iOS/Resources/Localization/de.lproj/Localizable.strings Fixes German hyphenation for the “send button” setting label.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Test Results

1 988 tests   1 961 ✅  2m 46s ⏱️
  324 suites     27 💤
    2 files        0 ❌

Results for commit 5d0ba25.

♻️ This comment has been updated with latest results.

Summary: workflow run #34340505966
Allure report (download zip): html-report-33259-fix_localization-german-WPB-27847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants