Skip to content

Conversation

@zskhan
Copy link
Contributor

@zskhan zskhan commented Dec 4, 2025

TaskWPB-21190 [Web] Calling - Close icon when selecting screen sharing has no accessible name

Pull Request

Summary

Add aria label and also title on the close screen share icon


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.74%. Comparing base (3b84817) to head (15deed4).
⚠️ Report is 10 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19845      +/-   ##
==========================================
+ Coverage   43.73%   43.74%   +0.01%     
==========================================
  Files        1299     1299              
  Lines       32744    32744              
  Branches     7268     7268              
==========================================
+ Hits        14321    14325       +4     
+ Misses      16703    16699       -4     
  Partials     1720     1720              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 71
  • Failed: 25
  • Skipped: 5
  • 🔁 Flaky: 8
  • 📊 Total: 109
  • Total Runtime: 409.7s (~ 6 min 50 sec)
specs/Accessibility/Accessibility.spec.ts (❌ 2 failed, ⚠️ 0 flaky)
  • ❌ Accessibility > I want to see collapsed view when app is narrow (tags: TC-48, regression)
  • ❌ Accessibility > I should not lose a drafted message when switching between conversations in collapsed view (tags: TC-51, regression)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 2 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
  • ❌ account settings > Verify links to manage and create teams are shown when logged in as team owner (tags: TC-1723, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > Verify the conversation is not unarchived when there are new messages in this conversation (tags: TC-99, regression)
specs/Authentication/authentication.spec.ts (❌ 6 failed, ⚠️ 0 flaky)
  • ❌ Authentication > Verify sign in error appearance in case of suspended team account (tags: TC-3468, regression)
  • ❌ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
  • ❌ Authentication > Verify sign in error appearance in case of wrong credentials (tags: TC-3465, regression)
  • ❌ Authentication > I want to keep my history after refreshing the page on temporary device (tags: TC-3473, regression)
  • ❌ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
  • ❌ Authentication > Verify session expired info is visible on login page (tags: TC-1311, regression)
specs/Block/block.spec.ts (❌ 1 failed, ⚠️ 1 flaky)
  • ❌ Block: User A and User B are NOT in the same team > Verify you can block a user who is not in your team (tags: TC-140, regression)
  • ⚠️ Block: User A and User B are NOT in the same team > Verify you still receive messages from blocked person in a group chat (tags: TC-141, regression)
specs/Connections/Connections.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Connections > Verify 1on1 conversation is not created on the second end after you ignore connection request (tags: TC-365, TC-369, TC-370, TC-371, regression)
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Account Management (tags: TC-8639, crit-flow-web)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/CriticalFlow/channelsCall-TC-8755.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Calls in channels with device switch and screenshare (tags: TC-8754, crit-flow-web)
specs/CriticalFlow/conversationManagement-TC-8636.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Conversation Management (tags: TC-8636, crit-flow-web)
specs/CriticalFlow/groupCalls-TC-8632.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)
specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Group Video call (tags: TC-8637, crit-flow-web)
specs/CriticalFlow/joinTeam-TC-8635.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)
specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)
specs/Edit/edit.spec.ts (❌ 1 failed, ⚠️ 2 flaky)
  • ❌ Edit > I see changed message if message was edited from another device (tags: TC-682, regression)
  • ⚠️ Edit > Editing a message does not create unread dot on receiver side (tags: TC-690, regression)
  • ⚠️ Edit > I can see the changed message was edited from another user (tags: TC-692, regression)
specs/LoginSpecs/login.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Verify you can sign in by email (tags: TC-3461, regression)
specs/RegressionSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Archive status of conversation should only change by user explicitly changing it (tags: TC-97, TC-99, TC-104, TC-105, regression)
specs/RegressionSpecs/block-messages.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block specs (tags: TC-141, regression)
specs/Reply/reply.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Reply > I want to see a placeholder text as quote when original message is not available anymore (tags: TC-2994, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 1 failed, ⚠️ 2 flaky)
  • ❌ Self Deleting Messages > Verify sending ephemeral text message in 1:1 (tags: TC-657, regression)
  • ⚠️ set globally in group conversation > I want to see the ephemeral indicator is updated in the input field if someone sets a global timer in conversation options (tags: TC-3719, regression)
  • ⚠️ in search results > I want to see ephemeral messages in the search results (tags: TC-3717, regression)

@zskhan zskhan force-pushed the feat/accessibility-close-screen-share-btn branch from b80638f to 6ec81d9 Compare December 4, 2025 15:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

@zskhan zskhan merged commit 58033d7 into dev Dec 8, 2025
15 checks passed
@zskhan zskhan deleted the feat/accessibility-close-screen-share-btn branch December 8, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants