Skip to content

feat: add aria label and also title on the close screen share icon [WPB-21190] #19845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zskhan merged 2 commits into from
Dec 8, 2025
Merged

feat: add aria label and also title on the close screen share icon [WPB-21190] #19845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ec81d9
feat: add aria label and also title on the close screen share icon
zskhan Dec 4, 2025
15deed4
Merge branch 'dev' into feat/accessibility-close-screen-share-btn
zskhan Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/i18n/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@
"callAccept": "Accept",
"callChooseSharedScreen": "Choose a screen to share",
"callChooseSharedWindow": "Choose a window to share",
"callChooseScreenCancel": "Close-screen sharing",
"callConversationAcceptOrDecline": "{conversationName} is calling. Press control + enter to accept the call or press control + shift + enter to decline the call.",
"callDecline": "Decline",
"callDegradationAction": "OK",
Expand Down
2 changes: 2 additions & 0 deletions src/script/components/calling/ChooseScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ function ChooseScreen({choose, callState = container.resolve(CallState)}: Choose
className="choose-screen-controls-button button-round button-round-dark button-round-md icon-close"
data-uie-name="do-choose-screen-cancel"
onClick={cancel}
aria-label={t('callChooseScreenCancel')}
title={t('callChooseScreenCancel')}
></button>
</div>
</div>
Expand Down
11 changes: 6 additions & 5 deletions src/types/i18n.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,6 @@ declare module 'I18n/en-US.json' {
'authLoginTitle': `Log in`;
'authPlaceholderEmail': `Email`;
'authPlaceholderPassword': `Password`;
'showTogglePasswordLabel': `Show password`;
'hideTogglePasswordLabel': `Hide password`;
'authPostedResend': `Resend to {email}`;
'authPostedResendAction': `No email showing up?`;
'authPostedResendDetail': `Check your email inbox and follow the instructions.`;
Expand Down Expand Up @@ -335,6 +333,7 @@ declare module 'I18n/en-US.json' {
'callAccept': `Accept`;
'callChooseSharedScreen': `Choose a screen to share`;
'callChooseSharedWindow': `Choose a window to share`;
'callChooseScreenCancel': `Close-screen sharing`;
'callConversationAcceptOrDecline': `{conversationName} is calling. Press control + enter to accept the call or press control + shift + enter to decline the call.`;
'callDecline': `Decline`;
'callDegradationAction': `OK`;
Expand Down Expand Up @@ -434,14 +433,14 @@ declare module 'I18n/en-US.json' {
'cells.options.delete': `Delete`;
'cells.options.deletePermanently': `Delete permanently`;
'cells.options.download': `Download`;
'cells.options.edit': `Edit`;
'cells.options.label': `More options`;
'cells.options.move': `Move to folder`;
'cells.options.open': `Open`;
'cells.options.rename': `Rename`;
'cells.options.restore': `Restore`;
'cells.options.share': `Share`;
'cells.options.tags': `Add or Remove Tags`;
'cells.options.edit': `Edit`;
'cells.pagination.loadMoreResults': `Load More Items`;
'cells.pagination.nextPage': `Next Page`;
'cells.pagination.previousPage': `Previous Page`;
Expand Down Expand Up @@ -1094,6 +1093,7 @@ declare module 'I18n/en-US.json' {
'guestRoomToggleInfoExtended': `Open this conversation to people outside your team. You can always change it later.`;
'guestRoomToggleInfoHead': `Guest Links`;
'guestRoomToggleName': `Allow Guests`;
'hideTogglePasswordLabel': `Hide password`;
'historyInfo.learnMore': `Learn more`;
'historyInfo.noHistoryHeadline': `It’s the first time you’re using {brandName} on this device.`;
'historyInfo.noHistoryInfo': `For privacy reasons, your history will not appear here.`;
Expand Down Expand Up @@ -1825,6 +1825,7 @@ declare module 'I18n/en-US.json' {
'setPassword.button': `Set password`;
'setPassword.headline': `Set password`;
'setPassword.passwordPlaceholder': `Password`;
'showTogglePasswordLabel': `Show password`;
'ssoLogin.codeInputPlaceholder': `SSO code`;
'ssoLogin.codeOrMailInputPlaceholder': `Email or SSO code`;
'ssoLogin.headline': `Company log in`;
Expand Down Expand Up @@ -1975,11 +1976,11 @@ declare module 'I18n/en-US.json' {
'userRemainingTimeHours': `{time}h left`;
'userRemainingTimeMinutes': `Less than {time}m left`;
'verify.changeEmail': `Change email`;
'verify.codeLabel': `Six-digit code`;
'verify.codePlaceholder': `Input field, enter digit`;
'verify.headline': `You’ve got mail`;
'verify.resendCode': `Resend code`;
'verify.subhead': `Enter the six-digit verification code we sent to{newline}{email}`;
'verify.codeLabel': `Six-digit code`;
'verify.codePlaceholder': `Input field, enter digit`;
'videoCallMenuMoreAddReaction': `Add reaction`;
'videoCallMenuMoreAudioSettings': `Audio Settings`;
'videoCallMenuMoreChangeView': `Change view`;
Expand Down
Loading