-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade docs site to Astro v3 #4461
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @ElianCodes! Looks surprisingly mostly OK on a quick browse around.
We might want to set scopedStyleStrategy: 'where'
in astro.config.mjs
just to be safe. I’ve only spotted one CSS detail off so far caused by specificity shifts with the new attribute default, but there might be some others lurking and shouldn’t do any harm to switch back to the :where()
approach.
I haven’t seen anything yet, but we should also keep an eye out for issues caused by compressHTML
now being enabled by default. Spotted a few issues in Starlight where spaces between inline elements were getting collapsed due to withastro/compiler#852
Very minor thing, but on Safari latest |
@itsmatteomanf, weird! It seems to work fine on my Safari! |
And now works for me, too. I tried refreshing, changing page, hard refreshing, and it stayed, but now decided to work. It's so interesting sometimes. |
Ok, now I see that, too. It doesn't happen all the time, but it does. |
Same with the language "tags" for not translated pages. |
I think it happens on components after the page's fold, here its possible to test both (before and after the fold) |
Yeah, it looks like some sort of issue with loading of the component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried every behavior I could remember and every combination of odd actions I could think of, with some special care on the tutorials. Everything is behaving correctly as far as I can tell, but I found a single asset problem.
The confirmation for the feedback form is broken.
Very very minor thing I noticed a little while ago - some faulty styling here. |
@VoxelMC That issue is in the live docs right now! Sharp eye, but it's not related to the v3 upgrade and needs its own fix. Would you like to make a separate PR to fix the indentation there? https://github.com/withastro/docs/edit/main/src/content/docs/en/guides/middleware.mdx |
Seems like the same problem is present in all translations, same fix for all of them. |
@sarah11918 I will do just that! |
@ElianCodes looks good now to me, the toggle for light/dark works perfectly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other client:visible
component usage seems to work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all the work on this @ElianCodes and everyone for checking in and reporting problems!
What kind of changes does this PR include?
Description
Todo:
astro-og-canvas
to catch up with v3 compatible versionKnown Bugs
[object object]
localStorage
)localStorage
)compressHTML
issue)Preview URL: https://deploy-preview-4461--astro-docs-2.netlify.app/