refactor: Organize GutenbergKit configuration #22165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GutenbergKit configuration logic by extracting the inline settings creation into a dedicated GutenbergKitSettingsBuilder object. The refactoring improves code organization by grouping related configuration data into logical classes and adding comprehensive test coverage for the complex plugin enablement logic and authentication flows.
- Extracted configuration logic into a dedicated builder with structured data classes
- Added comprehensive unit tests covering plugin logic, authentication flows, and complete scenarios
- Maintained existing functionality while improving code maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
GutenbergKitSettingsBuilderTest.kt |
New comprehensive test suite covering all configuration scenarios and edge cases |
GutenbergKitActivity.kt |
Refactored inline configuration logic into structured builder pattern with data classes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
WordPress/src/main/java/org/wordpress/android/ui/posts/GutenbergKitActivity.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/GutenbergKitActivity.kt
Outdated
Show resolved
Hide resolved
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22165-83d87a2 | |
| Commit | 83d87a2 | |
| Direct Download | wordpress-prototype-build-pr22165-83d87a2.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22165-83d87a2 | |
| Commit | 83d87a2 | |
| Direct Download | jetpack-prototype-build-pr22165-83d87a2.apk |
dcalhoun
force-pushed
the
refactor/improve-gutenberg-kit-configuration-organization
branch
from
395d2d8 to
1e67702
Compare
dcalhoun
changed the base branch from
trunk
to
refactor/remove-unused-jetpack-globals
dcalhoun
force-pushed
the
refactor/improve-gutenberg-kit-configuration-organization
branch
from
1e67702 to
6031322
Compare
Base automatically changed from
refactor/remove-unused-jetpack-globals
to
trunk
August 25, 2025 21:20
buildkite-limited-access
bot
requested review from
adalpari
and removed request for
a team
Handle edge cases with missing data.
dcalhoun
force-pushed
the
refactor/improve-gutenberg-kit-configuration-organization
branch
from
6031322 to
83d87a2
Compare
|
dcalhoun
deleted the
refactor/improve-gutenberg-kit-configuration-organization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Organize GutenbergKit settings into logical group. Add automated tests.
Testing instructions
Smoke test various editor functionality-media uploads, language settings, non-core blocks, various site types, etc.