Use newer versions of blade & gettext #443
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1 task
|
@copilot Can you help me bring this conversion/migration/upgrade over the finish line? |
19 tasks
|
@swissspidy I've opened a new pull request, #465, to work on those changes. Once the pull request is ready, I'll request review from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to 7.2 across the board I thought using gettext v5 would be a nice change...
However, there are a lot of changes, and the new version doesn't ship with a lot of the things we were using. For example there is no Jed support or
ParsedCommentclass anymore.Also, there are quite a few deprecation warnings on PHP 8.4 (implicit nullable)
Previously:
Fixes #303