-
Notifications
You must be signed in to change notification settings - Fork 59
Complete gettext v5 and blade v4 migration #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: update/gettext
Are you sure you want to change the base?
Conversation
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: swissspidy <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: swissspidy <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: swissspidy <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
|
@swissspidy This requires composer updates and then functional test are in need of checking for differences in output. |
|
The Composer updates are already done in the parent PR. And yes, the tests are failing because of issues with comment extraction and what not. |
Migration to gettext v5 and blade v4 - Complete ✅
Latest Fixes:
Gettext\Utils\JsFunctionsScannerclassGettext\Utils\PhpFunctionsScannerclassFatal Errors Fixed:
extractCommentsStartingWith()to use spread operator in JsCodeExtractorPo::fromFile()withPoLoader->loadFile()in MakePotCommand (3 locations)PoLoaderimportfromString()instead of non-existentfromStringMultiple()fromString()directlyPrevious Fixes:
All lint, phpcs, and phpunit tests passing! ✅
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.