Skip to content

misc tests: add type hints#401

Merged
glehmann merged 15 commits intomasterfrom
gln/misc-typehints
Apr 17, 2026
Merged

misc tests: add type hints#401
glehmann merged 15 commits intomasterfrom
gln/misc-typehints

Conversation

@glehmann
Copy link
Copy Markdown
Member

@glehmann glehmann commented Feb 15, 2026 •
edited
Loading

This allows more validation both in the CI and when writing the tests in our IDEs.

This work was mostly done with AI, validated by the code checkers, and manually cleaned up by me.

This PR is part of a stack containing 9 PRs:

  1. master
  2. Run the code checkers on the whole repository #387
  3. ssh: only allow string command #398
  4. add type hints to ./lib/ and ./conftest.py #399
  5. tests/storage: add type hints #400
  6. "misc tests: add type hints" (this PR)
  7. xapi,network: add type hints #402
  8. xen, guest_tools: add type hints #403
  9. misc type related enhancements #460
  10. chore: add ty type checker and reorder make commands for faster feedback #476

@glehmann glehmann requested a review from a team as a code owner February 15, 2026 21:59
@glehmann glehmann force-pushed the gln/misc-typehints branch 2 times, most recently from 2ffd7ed to 86cb57e Compare February 16, 2026 09:39
@glehmann glehmann force-pushed the gln/storage-typehints branch from c423343 to e4f54cc Compare February 16, 2026 09:39
@glehmann glehmann force-pushed the gln/storage-typehints branch from e4f54cc to 6faac7d Compare February 17, 2026 21:01
@glehmann glehmann force-pushed the gln/storage-typehints branch from 6faac7d to 60771ce Compare February 17, 2026 21:40
olivierh-pro
olivierh-pro reviewed Feb 18, 2026
View reviewed changes
Comment thread scripts/xcpng-fs-diff.py Outdated
@olivierh-pro olivierh-pro requested a review from a team February 18, 2026 08:42
olivierh-pro
olivierh-pro reviewed Feb 18, 2026
View reviewed changes
Comment thread tests/install/test_fixtures.py Outdated
olivierh-pro
olivierh-pro reviewed Feb 18, 2026
View reviewed changes
Comment thread tests/limits/test_vif_limit.py
olivierh-pro
olivierh-pro reviewed Feb 18, 2026
View reviewed changes
Comment thread tests/migration/test_cross_pool_migration.py
Comment thread tests/migration/test_host_evacuate.py
Comment thread tests/misc/test_access_links.py
Comment thread tests/misc/test_pool.py
Comment thread tests/packages/extra/conftest.py
Comment thread tests/uefi_sb/utils.py
Comment thread tests/vtpm/conftest.py
Comment thread tests/vtpm/test_vtpm_basic_operations.py
Comment thread tests/xo/test_xo_connection.py
Comment thread jobs.py Outdated
@olivierh-pro olivierh-pro requested a review from a team February 18, 2026 09:53
@glehmann glehmann force-pushed the gln/storage-typehints branch from 60771ce to e4ca4dd Compare February 19, 2026 21:29
@glehmann glehmann force-pushed the gln/storage-typehints branch from e4ca4dd to e658830 Compare February 19, 2026 21:49
@glehmann glehmann mentioned this pull request Feb 20, 2026
Merged
@glehmann glehmann force-pushed the gln/misc-typehints branch from 47c708a to ba07031 Compare March 2, 2026 22:23
@glehmann glehmann force-pushed the gln/storage-typehints branch 2 times, most recently from 68d3d1e to b66fa86 Compare March 9, 2026 20:53
@glehmann glehmann force-pushed the gln/misc-typehints branch from ba07031 to 4a34482 Compare March 9, 2026 20:53
@glehmann glehmann force-pushed the gln/misc-typehints branch from 4a34482 to 76857b0 Compare April 7, 2026 05:37
@glehmann glehmann requested review from a team as code owners April 7, 2026 05:37
@glehmann glehmann force-pushed the gln/storage-typehints branch from b66fa86 to b6031e7 Compare April 7, 2026 05:37
This was referenced Apr 7, 2026
Merged
Merged
@glehmann glehmann force-pushed the gln/storage-typehints branch from b6031e7 to 4cc7b08 Compare April 7, 2026 05:44
@glehmann glehmann force-pushed the gln/misc-typehints branch from 5d94a87 to bcad48f Compare April 7, 2026 09:31
@glehmann glehmann force-pushed the gln/storage-typehints branch from 4cc7b08 to ba42a8d Compare April 7, 2026 09:31
@olivierh-pro olivierh-pro requested a review from a team April 7, 2026 13:05
@glehmann glehmann force-pushed the gln/misc-typehints branch from bcad48f to 9a8d4f3 Compare April 13, 2026 20:50
@glehmann glehmann force-pushed the gln/storage-typehints branch 2 times, most recently from fd54d30 to 8f38e39 Compare April 15, 2026 17:07
@glehmann glehmann force-pushed the gln/misc-typehints branch from 9a8d4f3 to 12ba52a Compare April 15, 2026 17:07
@glehmann glehmann mentioned this pull request Apr 15, 2026
Draft
glehmann added 15 commits April 15, 2026 22:46
@glehmann
tests/fs_diff: add type hints
6973bd3 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/install: add type hints
ec14611 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/migration: add type hints
1659431 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/limits: add type hints
73cb1a2 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/misc: add type hints
df74aeb 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/packages: add type hints
d4d2b28 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/pci_passthrough: add type hints
774faa1 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/security: add type hints
91b6d20 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/snapshot: add type hints
4d8bf4f 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/system: add type hints
a4a0dee 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/uefi_sb: add type hints
81220f9 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/vtpm: add type hints
3df144e 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
tests/xo: add type hints
d9b42ba 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
scripts: add type hints
75dc161 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
jobs: add type hints
ed74ec4 
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann glehmann force-pushed the gln/storage-typehints branch from 8f38e39 to 63d20a9 Compare April 15, 2026 20:46
@glehmann glehmann force-pushed the gln/misc-typehints branch from 12ba52a to ed74ec4 Compare April 15, 2026 20:46
Base automatically changed from gln/storage-typehints to master April 17, 2026 13:48
@glehmann glehmann merged commit 5b696ad into master Apr 17, 2026
9 checks passed
@glehmann glehmann deleted the gln/misc-typehints branch April 17, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olivierh-pro olivierh-pro olivierh-pro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glehmann @olivierh-pro