Skip to content

chore: add ty type checker and reorder make commands for faster feedback#476

Draft
glehmann wants to merge 1 commit intogln/typehints-nextfrom
gln/add-ty-type-checker-nyml
Draft

chore: add ty type checker and reorder make commands for faster feedback#476
glehmann wants to merge 1 commit intogln/typehints-nextfrom
gln/add-ty-type-checker-nyml

Conversation

@glehmann
Copy link
Copy Markdown
Member

@glehmann glehmann commented Apr 15, 2026

Add ty as a development dependency for use as a language server in text
editors. ty provides fast type checking that complements pyright/mypy,
while ruff handles missing type hints detection.

Reorder make commands to run the fastest checks first (ruff, flake8, ty)
before the slower mypy and pyright, improving CI feedback speed.

Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech

This PR is part of a complex set of PRs containing 6 PRs:

  1. master
  2. Use passlib in place of legacycrypt #396master
  3. Introduce TOML-based configuration to replace data.py #491Use passlib in place of legacycrypt #396
  4. refactor: make BaseCmdResult and subclasses generic to eliminate runtime type narrowing #492master
  5. misc type related enhancements #460refactor: make BaseCmdResult and subclasses generic to eliminate runtime type narrowing #492
  6. "chore: add ty type checker and reorder make commands for faster feedback" (this PR) → misc type related enhancements #460
  7. Add Docker-based compatibility test kit for external validation #431refactor: make BaseCmdResult and subclasses generic to eliminate runtime type narrowing #492, Use passlib in place of legacycrypt #396

Copy link
Copy Markdown
Contributor

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to commit lock file on each changes ? i would only do this on release (using calver.org ?)

@glehmann
Copy link
Copy Markdown
Member Author

Do you want to commit lock file on each changes ? i would only do this on release (using calver.org ?)

Yes, it's meant to be used that way, to ensure that all developers are using the same dependency version.

@glehmann glehmann force-pushed the gln/add-ty-type-checker-nyml branch from 4cbb6bd to 7067fac Compare April 15, 2026 20:46
@glehmann glehmann force-pushed the gln/typehints-next branch from cda5129 to bfa602a Compare April 15, 2026 20:46
@glehmann glehmann changed the title chore: add ty type checker and reorder make commands for faster CI chore: add ty type checker and reorder make commands for faster feedback Apr 15, 2026
@olivierh-pro
Copy link
Copy Markdown
Contributor

If we use ty as type checker, should it be useful to add the related config for LSP in README ?

@glehmann glehmann force-pushed the gln/typehints-next branch from bfa602a to e0d3f3e Compare April 21, 2026 11:44
@glehmann glehmann force-pushed the gln/add-ty-type-checker-nyml branch from 7067fac to 20ed0c5 Compare April 21, 2026 11:44
@glehmann glehmann marked this pull request as draft April 21, 2026 11:44
@glehmann
Copy link
Copy Markdown
Member Author

We get errors with the newest versions. It's not ready yet for prime time. I'm moving this PR to draft

Add ty as a development dependency for use as a language server in text
editors. ty provides fast type checking that complements pyright/mypy,
while ruff handles missing type hints detection.

Reorder make commands to run the fastest checks first (ruff, flake8, ty)
before the slower mypy and pyright, improving feedback speed.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants