Log client app version in websocket to be displayed for admins #451
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consumed by admin websocket cluster page
…than setting it as a the data - unsure who could be overwriting data for their needs, so this seems safer for wide use
6 tasks
RyanMG
commented
Mar 18, 2025
| @@ -137,6 +137,9 @@ class WebSocketService extends BaseService implements EventPublisher { | |||
| def msgJSON = deserialize(message) | |||
|
|
|||
| if (msgJSON.topic == HEARTBEAT_TOPIC) { | |||
| def msgClientVersion = msgJSON.clientAppVersion; | |||
| channel.setClientAppVersion(msgClientVersion as String) | |||
There was a problem hiding this comment.
This coercion seems to work. I tried an update to now send any value from the client, and this did not crash or fail. But please let me know if there are better ways to access / set this data.
|
@amcclain -- Ryan and I are reviewing this. Unless you have any objections, will look to actually do this when the socket session is connected, rather than on every heartbeat -- its a minor difference, but will be a bit easier to reason about. |
- Update to client code now sends the client app version as part of the handshake URI, rather than in a heartbeat - helper method to extract all query params off URI - for potential future use
|
@lbwexler updated.
|
RyanMG
commented
Mar 25, 2025
src/main/groovy/io/xh/hoist/websocket/HoistWebSocketChannel.groovy
Outdated
Show resolved
Hide resolved
cr: David (pending)
lbwexler
approved these changes
Mar 25, 2025
lbwexler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket xh/hoist-react#3947
Server side update for xh/hoist-react#3948