-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log client app version in websocket heartbeats to be displayed for admins #3948
base: develop
Are you sure you want to change the base?
Conversation
Great, thanks for jumping on this! Just had a chance to update the ticket with a proper description. Goal is to get this version info into the Hoist admin console grid. We'll need to look at hoist-core to see how these messages are handled and thread that through into the |
… client's app version
- sent currently with heartbeat requests
type: 'string', | ||
displayName: 'Client App Version' | ||
}, | ||
width: 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
120 is holding "7.0 SNAPSHOT" with no issue, but unsure how much we expect this value could grow.
this.sendMessage({ | ||
topic: this.HEARTBEAT_TOPIC, | ||
data: 'ping', | ||
clientAppVersion: XH.appVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially made data
an object and sent clientAppVersion
as a property in said object.
I am unsure though how clients may be using this service. If they are extending and overriding data
in sendMessage
we would lose this value. However, there is also nothing stopping them from overriding heartbeatOrReconnect
either.
Open to suggestions or notes to help better understand real world use cases.
Ticket #3947
Server update here
Hoist P/R Checklist
develop
branch as of last change.breaking-change
label + CHANGELOG if so.