Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version v3.2.1 to the octree package. Feedback indicates that this version introduces breaking changes, including a header rename and API modifications, which will cause the existing test block to fail. The test configuration needs to be updated to support the new version's requirements.
| set_urls("https://github.com/attcs/Octree/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/attcs/Octree.git", {submodules = false}) | ||
|
|
||
| add_versions("v3.2.1", "1bc840bc34563419372391734b1283a10eb0eb224ba3f7d8c00880bdca47031f") |
There was a problem hiding this comment.
The update to v3.2.1 introduces breaking changes that will cause the package tests to fail. In the upstream repository (OrthoTree), the main header was renamed from octree.h to OrthoTree.h starting with version 3.0.0. Additionally, the API has changed significantly, meaning the code snippet in on_test (lines 34-47) which uses legacy types like OctreePointC will no longer compile. The on_test block needs to be updated to support the new version's header and API, potentially using version-aware logic to maintain compatibility with v2.5.
1 participant
New version of octree detected (package version: v2.5, last github version: v3.2.1)