Skip to content

Auto-update octree to v3.2.1 #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waruqi wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Auto-update octree to v3.2.1 #9818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/o/octree/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package("octree")
set_urls("https://github.com/attcs/Octree/archive/refs/tags/$(version).tar.gz",
"https://github.com/attcs/Octree.git", {submodules = false})

add_versions("v3.2.1", "1bc840bc34563419372391734b1283a10eb0eb224ba3f7d8c00880bdca47031f")
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The update to v3.2.1 introduces breaking changes that will cause the package tests to fail. In the upstream repository (OrthoTree), the main header was renamed from octree.h to OrthoTree.h starting with version 3.0.0. Additionally, the API has changed significantly, meaning the code snippet in on_test (lines 34-47) which uses legacy types like OctreePointC will no longer compile. The on_test block needs to be updated to support the new version's header and API, potentially using version-aware logic to maintain compatibility with v2.5.

add_versions("v2.5", "86088cd000254aeddf4f9d75c0600b7f799e062340394124d69760829ed317fe")

on_check(function (package)
Expand Down
Loading