Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for version 2.1.0 of the fmm3d package. A critical issue was identified where the new version's structural changes, such as relocated headers and renamed configuration files, will cause the existing installation logic to fail.
|
|
||
| set_urls("https://github.com/flatironinstitute/FMM3D/archive/refs/tags/$(version).zip", | ||
| "https://github.com/flatironinstitute/FMM3D.git") | ||
| add_versions("v2.1.0", "45974f21df0c9b2f9054bf729d7425715bb2a1ee2309d90852678fd50a69e80d") |
There was a problem hiding this comment.
The update to v2.1.0 is a major version jump that breaks the existing on_install logic. In v2.1.0, the project structure has changed significantly: C headers have moved from c/ to include/, and the make.inc configuration files have been renamed (e.g., make.inc.windows.mingw is now make.inc.mingw64). The current installation script will fail to find these files. You should update the on_install block to handle these changes, possibly by using version-specific logic.
1 participant
New version of fmm3d detected (package version: v1.0.4, last github version: v2.1.0)