Skip to content

Auto-update fmm3d to v2.1.0 #9824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waruqi wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −0
Open

Auto-update fmm3d to v2.1.0 #9824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/f/fmm3d/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package("fmm3d")

set_urls("https://github.com/flatironinstitute/FMM3D/archive/refs/tags/$(version).zip",
"https://github.com/flatironinstitute/FMM3D.git")
add_versions("v2.1.0", "45974f21df0c9b2f9054bf729d7425715bb2a1ee2309d90852678fd50a69e80d")
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The update to v2.1.0 is a major version jump that breaks the existing on_install logic. In v2.1.0, the project structure has changed significantly: C headers have moved from c/ to include/, and the make.inc configuration files have been renamed (e.g., make.inc.windows.mingw is now make.inc.mingw64). The current installation script will fail to find these files. You should update the on_install block to handle these changes, possibly by using version-specific logic.

add_versions("v1.0.4", "59fa04965cd46cd564ba4784d91f00f8b0d24e0a08967a7b90f076dd5eb30faf")

if is_plat("windows") then
Expand Down
Loading