add delete message content type #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Nov 13, 2025
| // DeleteMessage message type | ||
| message DeleteMessage { | ||
| // ID of the message to delete | ||
| string message_id = 1; |
Collaborator
There was a problem hiding this comment.
While I know that the platform SDKs typically treat message IDs as strings, we should think about whether we want to internally represent as bytes internally. One less encode/decode step and one less thing to validate (no possibility for encoding errors).
Contributor
Author
There was a problem hiding this comment.
Since we have the message_id everywhere - kinda e.g. in the ReactionV2, as string, I wanted to be consistent, but will update it.
Collaborator
There was a problem hiding this comment.
No, that's fair. We probably made a mistake initially having it as a string in the other content types. But I'm fine with erring on the side of consistency.
# Conflicts: # dev/kotlin/protoc/Dockerfile
rygine
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DeleteMessage content type to proto schema to support delete-message payloads in delete_message.proto
Introduce a
DeleteMessageprotobuf withstring message_id = 1;and set content type metadata (authority_idxmtp.org, type_iddeleteMessage, version 1.0), plus Go/Java package options.📍Where to Start
Start with the
DeleteMessagemessage definition and file-level options in delete_message.proto.Macroscope summarized b4b52c9.