-
Notifications
You must be signed in to change notification settings - Fork 7
add delete message content type #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
proto/mls/message_contents/content_types/delete_message.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // delete_message.proto | ||
| // This file defines the DeleteMessage message type and is associated with the following ContentTypeId: | ||
| // | ||
| // ContentTypeId { | ||
| // authority_id: "xmtp.org", | ||
| // type_id: "deleteMessage", | ||
| // version_major: 1, | ||
| // version_minor: 0, | ||
| // } | ||
| // | ||
| syntax = "proto3"; | ||
|
|
||
| package xmtp.mls.message_contents.content_types; | ||
|
|
||
| option go_package = "github.com/xmtp/proto/v3/go/mls/message_contents/content_types"; | ||
| option java_package = "org.xmtp.proto.mls.message_contents.content_types"; | ||
|
|
||
| // DeleteMessage message type | ||
| message DeleteMessage { | ||
| // ID of the message to delete | ||
| string message_id = 1; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I know that the platform SDKs typically treat message IDs as strings, we should think about whether we want to internally represent as bytes internally. One less encode/decode step and one less thing to validate (no possibility for encoding errors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have the message_id everywhere - kinda e.g. in the ReactionV2, as string, I wanted to be consistent, but will update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's fair. We probably made a mistake initially having it as a string in the other content types. But I'm fine with erring on the side of consistency.