Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PRODUCT_NAME for target.productName when present during multiplatform resolution #1165

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EricRabil
Copy link

@EricRabil EricRabil commented Jan 6, 2022

I love xcodegen, but when using multiplatform target generation I've always yearned for the ability to change the generated name in the Products group.
image
This PR sets the productName to PRODUCT_NAME when present, otherwise targetName
image

Since this alters behavior, I've placed this behind the productNameFromSettings flag within targets.

@EricRabil EricRabil changed the title Use produce name from settings as the reference name if present Use PRODUCT_NAME for target.productName when present Jan 6, 2022
@EricRabil EricRabil changed the title Use PRODUCT_NAME for target.productName when present Use PRODUCT_NAME for target.productName when present during multiplatform resolution Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant