Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PRODUCT_NAME for target.productName when present during multiplatform resolution #1165

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use PRODUCT_NAME for target.productName when present during multiplatform resolution #1165

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1382f1
Use produce name from settings as the reference name if present
EricRabil Jan 6, 2022
52f8206
Place productName override behind productNameFromSettings
EricRabil Jan 6, 2022
c442558
Merge pull request #1 from yonaskolb/master
EricRabil Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Sources/ProjectSpec/Target.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,18 +173,23 @@ extension Target {
let newTargetName = platformPrefix + targetName + platformSuffix

var settings = platformTarget["settings"] as? JSONDictionary ?? [:]
var newProductName: String?
if settings["configs"] != nil || settings["groups"] != nil || settings["base"] != nil {
var base = settings["base"] as? JSONDictionary ?? [:]
if base["PRODUCT_NAME"] == nil {
if let baseProductName = base["PRODUCT_NAME"] as? String {
newProductName = baseProductName
} else {
base["PRODUCT_NAME"] = targetName
}
settings["base"] = base
} else {
if settings["PRODUCT_NAME"] == nil {
if let productName = settings["PRODUCT_NAME"] as? String {
newProductName = productName
} else {
settings["PRODUCT_NAME"] = targetName
}
}
platformTarget["productName"] = targetName
platformTarget["productName"] = ((platformTarget["productNameFromSettings"] as? Bool == true) ? newProductName : nil) ?? targetName
platformTarget["settings"] = settings
if let deploymentTargets = target["deploymentTarget"] as? [String: Any] {
platformTarget["deploymentTarget"] = deploymentTargets[platform]
Expand Down