Add VR support to zedit #303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2023
This was referenced Nov 16, 2023
Member
|
Excellent PR! I will review the changes at length later. Thank you so much for your contribution to resolving this pain point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires z-edit/xelib#23 to be merged first. Adds some minor piping to add VR support, as well as providing new images for the two new VR profiles. It is just the normal profile image overlaid with a VR headset. The VR headset image comes from https://commons.wikimedia.org/wiki/File:VRHeadset.png and is public domain (Creative Commons Zero). Also updates the XEditLib.dll. Since this dll is a binary file, maybe the repo owner would prefer to build xedit-lib themselves after the above PR is merged instead of taking something from a stranger on the internet, and then this PR can discard the dll and just update piping / images.
Release build built using all of these combined changes here to verify changes: https://drive.google.com/file/d/1H2oJHLQuqJTkfelIPUkf1-m_KumzsLzF/view?usp=sharing