Timeout parameter change (Bug #34) #35
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter to the urlopen function instead of the Request object.
shifqu
reviewed
Nov 24, 2025
|
|
||
| try: | ||
| resp = ul.urlopen(req, context=ctx) | ||
| if self.timeout: |
There was a problem hiding this comment.
Why do we want to check if the timeout is set before passing it?
urlopen uses the socket's global default which, according to the docs, is None by default.
So IMO, we don't need to be defensive here and just pass the timeout, no matter what.
NOTE: I am not affiliated with zabbix_utils, merely a user of the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated api.py function send_api_request to pass the timeout parameter to the urlopen function instead of the Request object.