Skip to content

Timeout parameter change (Bug #34) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Timeout parameter change (Bug #34) #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions zabbix_utils/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ def send_api_request(self, method: str, params: Optional[dict] = None,
headers=headers,
method='POST'
)
req.timeout = self.timeout


# Disable SSL certificate validation if needed.
if not self.validate_certs:
Expand All @@ -360,7 +360,10 @@ def send_api_request(self, method: str, params: Optional[dict] = None,
ctx = None

try:
resp = ul.urlopen(req, context=ctx)
if self.timeout:
Copy link

@shifqu shifqu Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to check if the timeout is set before passing it?
urlopen uses the socket's global default which, according to the docs, is None by default.

So IMO, we don't need to be defensive here and just pass the timeout, no matter what.

NOTE: I am not affiliated with zabbix_utils, merely a user of the project.

resp = ul.urlopen(req, context=ctx, timeout=self.timeout)
else:
resp = ul.urlopen(req, context=ctx)
resp_json = json.loads(resp.read().decode('utf-8'))
except URLError as err:
raise ProcessingError(f"Unable to connect to {self.url}:", err) from None
Expand Down