Upgrade Flutter and packages #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: https://pub.dev/packages/pigeon/changelog#2500 There's one breaking change which removes an option we don't use, so it shouldn't affect us. This commit is the result of running these commands: flutter pub upgrade --major-versions pigeon ./tools/check pigeon --all-files --fix
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Mar 27, 2025
Done by building for iOS, with Xcode 16.2 (16C5032a). I suspect the Xcode-file update is due to an Xcode upgrade. I think the Podfile.lock changes are needed because zulip#1426 didn't include the `pod` step of `tools/upgrade`.
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Mar 27, 2025
I think the Podfile.lock changes are needed because zulip#1426 didn't include the `pod` step of `tools/upgrade`. I suspect the Xcode-file update is due to an Xcode upgrade. Done by building for iOS, with Xcode 16.2 (16C5032a), then (when I remembered that macOS/Podfile.lock needs updating too) `tools/upgrade pod`.
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Mar 27, 2025
Greg found that this is a side effect of the Flutter upgrade in PR zulip#1426: zulip#1444 (comment) > And indeed, `git log -G flutter_lldbinit` in the Flutter tree > finds this from earlier this month, 2025-03-06: > flutter/flutter@eb07c5123 Committing it here, after building for iOS, which we forgot to do when preparing that PR.
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Mar 27, 2025
These are needed because zulip#1426 didn't include the `pod` step of `tools/upgrade`. Done by building for iOS, then (when I remembered that macOS/Podfile.lock needs updating too) `tools/upgrade pod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first three commits (the non-draft commits) from @rajveermalviya's #1422, split out to expedite merging them.