chore: set the default of _should_skip to false

[wantsui]

While reviewing the flaky marker in gunicorn's test_span_schematization in

dd-trace-py/tests/contrib/gunicorn/test_gunicorn.py

Line 188 in 223c261

@flaky(until=1706677200)

, @brettlangdon pointed out that the timestamp is long past.

ie:

@flaky(until=1706677200)

This translates to Jan 31, 2024.

However, if you run the test for test_span_schematization today, it passes fine because it is getting skipped:

1 passed with 0 warnings, 0 failed

The bug fix here is to set the default to false, but keep the spirit of the original condition if statement.

If you rerun the test_span_schematization with this branch, it now doesn't get skip and the test correctly fails:

FAILED tests/contrib/gunicorn/test_gunicorn.py::test_span_schematization - AttributeError: module 'ddtrace.internal.compat' has no attribute 'stringify'

Leaving this PR in a draft state for now to see what other tests this affects.

Checklist

• PR author has checked that all the criteria below are met
• The PR description includes an overview of the change
• The PR description articulates the motivation for the change
• The change includes tests OR the PR description describes a testing strategy
• The PR description notes risks associated with the change, if any
• Newly-added code is easy to change
• The change follows the library release note guidelines
• The change includes or references documentation updates if necessary
• Backport labels are set (if applicable)

Reviewer Checklist

• Reviewer has checked that all the criteria below are met
• Title is accurate
• All changes are related to the pull request's stated goal
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Newly-added code is easy to change
• Release note makes sense to a user of the library
• If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[github-actions]

CODEOWNERS have been resolved as:

tests/utils.py                                                          @DataDog/python-guild

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: wantsui/fix-should-skip
Commit report: ebfb726
Test service: dd-trace-py

✅ 0 Failed, 958 Passed, 328 Skipped, 22m 53.01s Total duration (13m 53.72s time saved)

[quinna-h]

Suggested change

	if condition is not None and condition:
	return True
	return False
	return condition is not None and condition

[quinna-h]

nit suggestion

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-11-14 22:41:19

Comparing candidate commit ebfb726 in PR branch wantsui/fix-should-skip with baseline commit bd0097f in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 386 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathjoin_aspect

• 🟩 execution_time [-720.995ns; -648.395ns] or [-12.171%; -10.946%]

scenario:iast_aspects-ospathnormcase_aspect

• 🟩 execution_time [-244.555ns; -208.504ns] or [-9.142%; -7.795%]