fix[next]: Fix canonicalize unstructured domain in GTFN lowering #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This particular issue is also addressed in #2403, but we found a more fundamental issue the is still blocking. |
Contributor
Author
Thanks, this explains why the icon4py stencil ( |
…x_canonicalize_domain
Contributor
Author
|
The simple fix does not work. Closing this PR because the issue was already reported in #2403. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GTFN IR pass
_CannonicalizeUnstructuredDomainonly supports domain expressions with two dimensions, so it should skip domains with only one (vertical) dimension.