Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/gt4py/next/program_processors/codegens/gtfn/itir_to_gtfn_ir.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,17 +206,27 @@ def _bool_from_literal(node: itir.Node) -> bool:

class _CannonicalizeUnstructuredDomain(eve.NodeTranslator):
def visit_FunCall(self, node: itir.FunCall) -> itir.FunCall:
if node.fun == itir.SymRef(id="unstructured_domain"):
if cpm.is_call_to(node, "unstructured_domain"):
# for no good reason, the domain arguments for unstructured need to be in order (horizontal, vertical)
assert isinstance(node.args[0], itir.FunCall)
first_axis_literal = node.args[0].args[0]
assert isinstance(first_axis_literal, itir.AxisLiteral)
if first_axis_literal.kind == itir.DimensionKind.VERTICAL:
assert len(node.args) == 2
assert isinstance(node.args[1], itir.FunCall)
assert isinstance(node.args[1].args[0], itir.AxisLiteral)
assert node.args[1].args[0].kind == itir.DimensionKind.HORIZONTAL
return itir.FunCall(fun=node.fun, args=[node.args[1], node.args[0]])
if len(node.args) == 1:
if first_axis_literal.kind == itir.DimensionKind.VERTICAL:
# a horizontal domain is needed in unstructured, so we convert a K-only domain to cartesian
dim = common.Dimension(first_axis_literal.value, first_axis_literal.kind)
return im.domain(
common.GridType.CARTESIAN,
{dim: (node.args[0].args[1], node.args[0].args[2])},
)
elif len(node.args) == 2:
if first_axis_literal.kind == itir.DimensionKind.VERTICAL:
assert isinstance(node.args[1], itir.FunCall)
assert isinstance(node.args[1].args[0], itir.AxisLiteral)
assert node.args[1].args[0].kind == itir.DimensionKind.HORIZONTAL
return itir.FunCall(fun=node.fun, args=[node.args[1], node.args[0]])
else:
raise NotImplementedError("Only up to two dimensional domains are supported.")
return node

@classmethod
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ def testee(a: cases.IJKField) -> cases.IJKField:
cases.verify_with_default_data(cartesian_case, testee, ref=lambda a: a)


def test_copy_vertical(unstructured_case_3d):
@gtx.field_operator
def testee(a: cases.KField) -> cases.KField:
return a

cases.verify_with_default_data(unstructured_case_3d, testee, ref=lambda a: a)


@pytest.mark.uses_tuple_returns
def test_multicopy(cartesian_case):
@gtx.field_operator
Expand Down
Loading