rpc-alt: testing query transaction + pruning #21190
Open
+431
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
6f78de6 to
31d89ba
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
31d89ba to
6a9183d
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
6a9183d to
7d51f89
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
7d51f89 to
4ea0ca4
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
4ea0ca4 to
ba0a812
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
ba0a812 to
56c96a5
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
## Description Adding a test to make sure that transaction querying continues to work in the presence of pruning, because there is some tricky logic related to applying a lowerbound to the filtered results. At the same time, I also created a testing-specific config for the indexer, which speeds up polling but reduces concurrency -- this shaves off about 10 to 15s from local testing runs overall, and 30s for the newly added test (which generates a lot of checkpoints). ## Test plan ``` sui$ cargo nextest run -p sui-indexer-alt-e2e-tests \ --test transaction_pruning_tests ```
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
56c96a5 to
66a1c18
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a test to make sure that transaction querying continues to work in the presence of pruning, because there is some tricky logic related to applying a lowerbound to the filtered results.
At the same time, I also created a testing-specific config for the indexer, which speeds up polling but reduces concurrency -- this shaves off about 10 to 15s from local testing runs overall, and 30s for the newly added test (which generates a lot of checkpoints).
Test plan
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.