Remove unused dependencies #383
Conversation
bayc
added
dependencies
medium priority
| @@ -15,29 +15,23 @@ dependencies = [ | |||
| "NREL-PySAM==4.2.0", | |||
| "Pillow", | |||
| "Pyomo>=6.1.2", | |||
| "diskcache", | |||
There was a problem hiding this comment.
The docs build is failing because alt_dev requires this package. Was this just an unused import, or is it actually used in the model?
There was a problem hiding this comment.
Yea, just noticed that as well. It appears to be used in alt_dev, which I imagine several of the other packages were also used in. I've reached out to @dguittet to see if this directory should be kept around or not. Looks like the last development was 2 years ago (we moved some resource files 5 months ago, but that was done to the whole repo).
There was a problem hiding this comment.
Confirmed with @qualand that the directory could be removed for the next release.
No idea how I commented on the wrong PR, please ignore this comment. |
bayc
added
high priority
Remove unused dependencies
This PR just removes currently unused dependencies. These were used for code in the
alt_devdirectory, developed by @qualand, who has approved removal of them for now and asked that we consider integrating them into future development. Also removedpyyaml-includeas we use theload_yamlutility function now that uses the standardyamlpackage.Related issue
Closes #303
Impacted areas of the software
pyproject.tomlAdditional supporting information
None.
Test results, if applicable
Tests were passing on my fork. Looking into the failing tests now. Seems readthedocs is failing because of missing packages for the
alt_devdirectory. Confirming with @dguittet whether that directory is still needed or not.