feat: Add time_zone to Datetime column#33
Conversation
allows setting a time zone for datetimes and checking if the values in the column matches it
time_zone to Datetime resultstime_zone to Datetime results
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 1887 1890 +3
=========================================
+ Hits 1887 1890 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Andreas Albert (AndreasAlbertQC)
left a comment
There was a problem hiding this comment.
Thanks for the nice PR Dylan Frankland (@dfrankland)! Could you add a test in test_sql_schema.py for the oracle part?
Oliver Borchert (borchero)
left a comment
There was a problem hiding this comment.
Thanks for the initiative Dylan Frankland (@dfrankland), I think this is a very useful addition! :)
time_zone to Datetime resultstime_zone to Datetime results
|
Let me know if you'd like for me to rebase these changes |
8de8c8f to
30e3538
Compare
Oliver Borchert (borchero)
left a comment
There was a problem hiding this comment.
All right, nice, I think we're almost there! :)
|
Updated to keep things minimal and also made the test name more accurate |
Oliver Borchert (borchero)
left a comment
There was a problem hiding this comment.
Thank you for the updates! Just one tiny comment left :)
time_zone to Datetime resultstime_zone to Datetime column
There was a problem hiding this comment.
I quickly took care of the small remaining comments to finally merge this -- thanks for your work Dylan Frankland (@dfrankland)!
ea591aa
into
Quantco:main
|
Oliver Borchert (@borchero) not a problem at all, thank you! |
Motivation
Closes #32
Changes
allows setting a time zone for datetimes and checking if the values in the column matches it
Pertinent polars docs:
https://docs.pola.rs/user-guide/transformations/time-series/timezones/