chore: Update DEVELOPMENT.md with LLVM 21 setup instructions#2935
Merged
chore: Update DEVELOPMENT.md with LLVM 21 setup instructions#2935
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 267 267
Lines 52975 52975
Branches 46914 46914
=======================================
Hits 44384 44384
Misses 6320 6320
Partials 2271 2271
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aborgna-q
force-pushed
the
ab/llvm-21-instructions
branch
from
b58e035 to
122e1f4
Compare
acl-cqc
approved these changes
Mar 16, 2026
Contributor
acl-cqc
left a comment
acl-cqc
left a comment
There was a problem hiding this comment.
Looks good, thanks.
On Mac it was brew install llvm@21 and then setting the LLVM_SYS_211_PREFIX thing
DEVELOPMENT.md
Outdated
| - Optional: llvm `== 14.0`. The "llvm" feature (backed by the sub-crate `hugr-llvm`) | ||
| requires LLVM installed. We use the rust bindings | ||
| - Optional: llvm `== 21.1`. The "llvm" feature (backed by the sub-crate `hugr-llvm`) | ||
| requires LLVM 21.0 installed. We use the rust bindings |
Contributor
There was a problem hiding this comment.
I think this should be 21.1?
DEVELOPMENT.md
Outdated
| requires LLVM installed. We use the rust bindings | ||
| - Optional: llvm `== 21.1`. The "llvm" feature (backed by the sub-crate `hugr-llvm`) | ||
| requires LLVM 21.0 installed. We use the rust bindings | ||
| [llvm-sys](https://crates.io/crates/llvm-sys) to [llvm](https://llvm.org/). |
Contributor
There was a problem hiding this comment.
Drive-by nit: this seems odd; surely it's the capital LLVM on the previous line that should be the link?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.