-
Notifications
You must be signed in to change notification settings - Fork 15
chore: Update DEVELOPMENT.md with LLVM 21 setup instructions #2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,8 +34,8 @@ To setup the environment manually you will need: | |
| - uv `>=0.7`: <https://docs.astral.sh/uv/getting-started/installation> | ||
| - Optional: capnproto `>=1.0`: <https://capnproto.org/install.html> | ||
| Required when modifying the `hugr-model` serialization schema. | ||
| - Optional: llvm `== 14.0`. The "llvm" feature (backed by the sub-crate `hugr-llvm`) | ||
| requires LLVM installed. We use the rust bindings | ||
| - Optional: llvm `== 21.1`. The "llvm" feature (backed by the sub-crate `hugr-llvm`) | ||
| requires LLVM 21.0 installed. We use the rust bindings | ||
| [llvm-sys](https://crates.io/crates/llvm-sys) to [llvm](https://llvm.org/). | ||
|
||
|
|
||
| Once you have these installed, you can install the required python dependencies and setup pre-commit hooks with: | ||
|
|
@@ -46,11 +46,11 @@ just setup | |
|
|
||
| #### Note on LLVM | ||
|
|
||
| You will need llvm 14.0 installed in order for `just check` to run all its | ||
| You will need llvm 21.1 installed in order for `just check` to run all its | ||
| checks successfully. On Debian-based systems you can install it as the | ||
| `llvm-14` package; you will also need to install `libpolly14-dev`. You should | ||
| set the environment variable `LLVM_SYS_140_PREFIX` to point to its location | ||
| (e.g. `/usr/lib/llvm-14`) when running `just check`. | ||
| `llvm-21` package; you may also need to install `libpolly21-dev`. You should | ||
| set the environment variable `LLVM_SYS_211_PREFIX` to point to its location | ||
| (e.g. `/usr/lib/llvm-21`) when running `just check`. | ||
|
|
||
| ## 🏃 Running the tests | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 21.1?