-
-
Notifications
You must be signed in to change notification settings - Fork 115
Do not reset the servicevm feature on domain load
#740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since the feature is set/reset on `provides_network` property change, and we have the salt states readjusted for default servicevms, we do not need to set/reset this specific feature for every domain on load event fixes: QubesOS/qubes-issues#7298
|
PipelineRetry |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 70.34% 70.39% +0.05%
==========================================
Files 61 61
Lines 13682 13679 -3
==========================================
+ Hits 9625 9630 +5
+ Misses 4057 4049 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025102219-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 84 fixed
Unstable testsPerformance TestsPerformance degradation:17 performance degradations
Remaining performance tests:163 tests
|
Since the feature is set/reset on
provides_networkproperty change, and we have the salt states readjusted for default servicevms, we do not need to set/reset this specific feature for every domain on load eventfixes: QubesOS/qubes-issues#7298