-
-
Notifications
You must be signed in to change notification settings - Fork 44
Fix qui-update icons
#281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix qui-update icons
#281
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 93.01% 92.98% -0.04%
==========================================
Files 64 64
Lines 13277 13278 +1
==========================================
- Hits 12350 12346 -4
- Misses 927 932 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks good, btw, what tool did you use to fix those? the output svgs are lovely. |
First of all, I changed the image dimensions and units from millimeters to 48x48 in Inkscape. Then I used the same tool which was used to optimize other icons 3 months ago (SVGO). This tool cleans the SVG source and removes unnecessary metadata. But since SVGO is not available in default Fedora repositories and had to be installed via npm, I did it in a DispVM. This still needs openQA to see if really fixes the issue. |
@marmarek Could this go through openQA? It is just 3 icons. But having observing the outcome in openQA would be nice (according to original issue). |
|
See https://openqa.qubes-os.org/tests/155939#step/qui_widgets_update/10, it's still cut a bit |
7353e38 to
b789a75
Compare
I scaled them down a little bit (similar to other ones). Let's see if makes a difference this time. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025102219-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 84 fixed
Unstable testsPerformance TestsPerformance degradation:17 performance degradations
Remaining performance tests:163 tests
|
@marmarek This time the test failed since the icons were not cropped and the needles did not match? |
|
This was still from before your last push. |
resolves: QubesOS/qubes-issues#10269