Skip confusing buttons from dom0 and disp template #67
Conversation
Can the button be retained, but in the APPS tab start a new disposable (without any application)? |
|
But also, @marmarta we noticed at the summit possible UX issue here: when searching for disposable template name (for example default-dvm), you get results from both disposable template and for starting new disposable based on that template. Those entries are slightly different, but it's easy to confuse them... |
What will hold the disposable open? A terminal? We will be deviating from unnamed disposable destroying when closing the initial application. About the limitation of "APPS" and "TEMPLATES" tab, it may be that I just didn't find the solution to identify which tab it is... |
That's a good question. If you just start it (using qvm-start, possibly modified to support it) it would need to be killed manually... |
Two things here: 
It might make sense to have the
|
|
PipelineRetryFailed |
This is strange and appears only on tests... |
|
Maybe test don't initialize application object? |
Yeah, not even toplevel is initialized... trying to find a test that depends on the toplevel being set... any help from Gtk experts welcome. |
ben-grande
force-pushed
the
hide-dvm-start
branch
from
d440e18 to
8eebba7
Compare
|
The solution was to pass the whole vm_entry object as it already has all the necessary info such as vm_name and power_state. |
|
To test the running disposable template, this PR requires QubesOS/qubes-core-admin-client#384 |
that is probably a good idea. Right now yeah, it's an improvement but it's a little confusing. |
I agree it can be a bit confusing, it was actually an improvement from the old app menu that had
And that caused problems, so I am not sure if my idea was good or not right now. I looked at the code a bit more, I was thinking of duplicating the VMEntry for disposable templates and adding But having duplicate qube entries get worse when you have some disposable templates. If you have 3 disposable templates, you will have 6 qube entries on the search.... not so fun anymore. |
I enjoy the new menu separation of APPS and TEMPLATES, but for this "Start qube" action, it needs different objects to be loaded at each tab and also for search to have different entries to have at least one that can start the qube. I looked a bit more and it seems that there will be a lot of duplication if I start using different objects for the qube for different tabs. I also looked at |
ben-grande
force-pushed
the
hide-dvm-start
branch
from
8eebba7 to
e0a193e
Compare
|
I don't think that two groups per disp template is a problem though? I think that in some ideal world there would be a custom magical panel to the side, but I think this is a problem for a future bigger menu improvements project; right now having two categories would solve the issue here? Unless I misunderstood the last comment and it's not possible here.. |
ben-grande
force-pushed
the
hide-dvm-start
branch
from
e0a193e to
dda9d80
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 80.42% 80.82% +0.39%
==========================================
Files 23 23
Lines 2779 2800 +21
==========================================
+ Hits 2235 2263 +28
+ Misses 544 537 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The |
ben-grande
force-pushed
the
hide-dvm-start
branch
2 times, most recently
from
4833c62 to
398be69
Compare
The new behavior: "Start qube" is hidden from the "APPS" tab but is shown on the "TEMPLATES" tab and the "Search" page. I avoided two VM entries as it seems rather complex to have a clone that replicates everything that is made to the clone, such as updating vm state, properties, features etc. There might be a way though, the same way I thought that the tab identification was difficult and it was simple, I was just looking at the wrong places. |
- Dom0: hide shutdown and pause, technically, shutdown can be used by GUIVMs in the future if the action was modified, currently, qubesd logs a failure. - Disposables templates have the "Start qube" button in the "TEMPLATES" tab and the "Search" page, but not in the "APPS" tab. Fixes: QubesOS/qubes-issues#10288 For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
hide-dvm-start
branch
from
398be69 to
b44889e
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025103005-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests19 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 82 fixed
Unstable testsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:165 tests
|
I am not sure about it, no.
Ok, I think this works. I'll review this. |
4 participants
Fixes: QubesOS/qubes-issues#10288
For: QubesOS/qubes-issues#1512
Requires: QubesOS/qubes-core-admin-client#384