autoname: Avoid integer overflow #5277
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Originally posted by @jix in #5081 (comment)
Explain how this is achieved.
Alternative approach to #5081 which leaves the score as-is and only compares the name length as necessary. It also changes the wire score from
int
tounsigned int
so that instead of overflowing if the score is overINT32_MAX/20000
, the wire fanout now needs to be overINT32_MAX
, and is never dependent on the name length.This avoids the integer overflow and may be preferable, but the test case from #4983 still crashes.
Also includes a fix for
autoname
to support selection arguments, matching the behaviour in the help message.If applicable, please suggest to reviewers how they can test the change.