Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tracker_object_merger): add diagnostics #10257

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

MasatoSaeki
Copy link
Contributor

@MasatoSaeki MasatoSaeki commented Mar 11, 2025

Description

Add diagnostics to judge following case.

  • main msg(e.g. lidar) is delay
  • main msg(e.g. lidar) continues to be empty
  • sub msg(e.g. radar) is delay

Related links

autowarefoundation/autoware_launch#1357

Parent Issue:

  • Link

How was this PR tested?

https://evaluation.ci.tier4.jp/evaluation/reports/e019a2e3-0b9e-50f6-a238-abb79d8148a0?project_id=prd_jt

I checked certain rosbag w/o radar msg.

Screencast.from.03-12-2025.04.59.34.PM.webm
ros2 launch autoware_launch logging_simulator.launch.xml \
        map_path:=$MAP_PATH \
        pointcloud_map_file:=$MAP_PCD_FILE \
        vehicle_model:=$VEHICLE_MODEL \
        sensor_model:=$SENSOR_MODEL \
        vehicle_id:=$VEHICLE_ID \
        vehicle:=true \
        system:=true \
        map:=true \
        sensing:=true \
        perception:=true \
        localization:=false \
        planning:=false \
        control:=false \
        perception_mode:=camera_lidar_radar_fusion
ros2 bag play hogehoge --clock
ros2 run rqt_runtime_monitor rqt_runtime_monitor

Notes for reviewers

None.

Interface changes

Change type Topic Type Topic Name Message Type Description
Added Pub /diagnostics diagnostic_msgs/msg/DiagnosticArray Topic description

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 11, 2025
Copy link

github-actions bot commented Mar 11, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

diagnostics_interface_ptr_->add_key_value("delay_main_objects", delay_main_objects);
if (delay_main_objects > diag_delay_main_objects_tolerance_) {
std::stringstream message;
message << "Main object is delayed for longer than tolerance";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to indicate the tolerance value comparing with the current delay value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in bcbd2ff

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 12, 2025
MasatoSaeki and others added 10 commits March 12, 2025 17:04
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: Taekjin LEE <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
@MasatoSaeki MasatoSaeki force-pushed the feat/add_diag_tracking_object_merger branch from a1eb957 to b63f4f6 Compare March 12, 2025 08:04
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 26.21%. Comparing base (8ae942f) to head (ea440f0).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ject_merger/src/decorative_tracker_merger_node.cpp 0.00% 52 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10257      +/-   ##
==========================================
- Coverage   26.23%   26.21%   -0.02%     
==========================================
  Files        1378     1378              
  Lines      107490   107552      +62     
  Branches    41444    41450       +6     
==========================================
- Hits        28199    28198       -1     
- Misses      76465    76528      +63     
  Partials     2826     2826              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.23% <ø> (-0.01%) ⬇️ Carriedforward from a10ae33

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: MasatoSaeki <[email protected]>
@MasatoSaeki MasatoSaeki marked this pull request as ready for review March 12, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants