-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_tracker_object_merger): add diagnostics #10257
base: main
Are you sure you want to change the base?
feat(autoware_tracker_object_merger): add diagnostics #10257
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
diagnostics_interface_ptr_->add_key_value("delay_main_objects", delay_main_objects); | ||
if (delay_main_objects > diag_delay_main_objects_tolerance_) { | ||
std::stringstream message; | ||
message << "Main object is delayed for longer than tolerance"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to indicate the tolerance value comparing with the current delay value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bcbd2ff
perception/autoware_tracking_object_merger/src/decorative_tracker_merger_node.cpp
Show resolved
Hide resolved
perception/autoware_tracking_object_merger/src/decorative_tracker_merger_node.cpp
Outdated
Show resolved
Hide resolved
perception/autoware_tracking_object_merger/src/decorative_tracker_merger_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Co-authored-by: Taekjin LEE <[email protected]> Signed-off-by: MasatoSaeki <[email protected]>
a1eb957
to
b63f4f6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10257 +/- ##
==========================================
- Coverage 26.23% 26.21% -0.02%
==========================================
Files 1378 1378
Lines 107490 107552 +62
Branches 41444 41450 +6
==========================================
- Hits 28199 28198 -1
- Misses 76465 76528 +63
Partials 2826 2826
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: MasatoSaeki <[email protected]>
Description
Add diagnostics to judge following case.
Related links
autowarefoundation/autoware_launch#1357
Parent Issue:
How was this PR tested?
https://evaluation.ci.tier4.jp/evaluation/reports/e019a2e3-0b9e-50f6-a238-abb79d8148a0?project_id=prd_jt
I checked certain rosbag w/o radar msg.
Screencast.from.03-12-2025.04.59.34.PM.webm
Notes for reviewers
None.
Interface changes
/diagnostics
diagnostic_msgs/msg/DiagnosticArray
Effects on system behavior
None.