-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_universe_utils): fix procedure to check if point is on edge #10260
fix(autoware_universe_utils): fix procedure to check if point is on edge #10260
Conversation
Signed-off-by: mitukou1109 <[email protected]>
Signed-off-by: mitukou1109 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
thanks! after merging this PR, please sent same one to https://github.com/autowarefoundation/autoware_utils too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go deep into the implementation, but seems good to me.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10260 +/- ##
==========================================
- Coverage 26.24% 26.23% -0.02%
==========================================
Files 1378 1378
Lines 107485 107540 +55
Branches 41443 41466 +23
==========================================
+ Hits 28210 28212 +2
- Misses 76453 76505 +52
- Partials 2822 2823 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR fixes the procedure in
covered_by()
andwithin()
functions to check if the given point is on any edge of the given polygon.Related links
internal: https://star4.slack.com/archives/C0575HP7NJG/p1741675912882399
How was this PR tested?
Benchmark results with 100 randomly generated polygons with 9 vertices:
covered_by()
within()
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.