fix(autoware_universe_utils): fix procedure to check if point is on edge #10260
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(2 files with Complex Method, Large Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| test_alt_geometry.cpp | 1 advisory rule | 5.95 → 5.92 | Suppress |
| alt_geometry.cpp | 1 advisory rule | 6.89 → 6.99 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| alt_geometry.cpp | 6.89 → 6.99 | Bumpy Road Ahead |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method alt_geometry.cpp: within
- Complex Method alt_geometry.cpp: covered_by
- Large Method test_alt_geometry.cpp: TEST:alt_geometry:within
✅ Improving Code Health:
- Bumpy Road Ahead alt_geometry.cpp: covered_by
- Bumpy Road Ahead alt_geometry.cpp: within
Annotations
Check warning on line 628 in common/autoware_universe_utils/src/geometry/alt_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
within increases in cyclomatic complexity from 14 to 17, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 289 in common/autoware_universe_utils/src/geometry/alt_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
covered_by increases in cyclomatic complexity from 14 to 17, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 289 in common/autoware_universe_utils/src/geometry/alt_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
covered_by is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 628 in common/autoware_universe_utils/src/geometry/alt_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
within is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 698 in common/autoware_universe_utils/test/src/geometry/test_alt_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
TEST:alt_geometry:within increases from 75 to 84 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.