fix(costmap_generator): use vehicle frame for lidar height thresholds #9311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix how the lidar height min/max thresholds are used in the
costmap_generator
.They were originally designed to be thresholds relative to the lidar frame. However, they are compared to points converted to the costmap frame (
map
by default).Since the lidar frame is not easily available in the
costmap_generator
, the PR changes the parameters to represent thresholds in the vehicle frame (base_link
by default) and correctly converts the thresholds to the costmap frame.Launch PR to update the parameters: autowarefoundation/autoware_launch#1225
How was this PR tested?
Using the sample map which has a z value of around 19m.
perception/enable_object_recognition:=false
.Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.