Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(costmap_generator): use vehicle frame for lidar height thresholds #9311

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Nov 13, 2024

Description

Fix how the lidar height min/max thresholds are used in the costmap_generator.
They were originally designed to be thresholds relative to the lidar frame. However, they are compared to points converted to the costmap frame (map by default).
Since the lidar frame is not easily available in the costmap_generator, the PR changes the parameters to represent thresholds in the vehicle frame (base_link by default) and correctly converts the thresholds to the costmap frame.

Launch PR to update the parameters: autowarefoundation/autoware_launch#1225

How was this PR tested?

Using the sample map which has a z value of around 19m.

  • Run the planning simulation with perception/enable_object_recognition:=false.
  • Set the ego pose inside the parking area.
  • Visualize the costmap.
  • Place a bus inside the costmap.
  • Without this PR: obstacle points are not reflected in the costmap.
  • With this PR: the costmap correctly reflects the obstacle points.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.28%. Comparing base (d187722) to head (5adbdc2).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...toware_costmap_generator/src/costmap_generator.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9311      +/-   ##
==========================================
- Coverage   29.29%   29.28%   -0.01%     
==========================================
  Files        1334     1334              
  Lines      102789   102797       +8     
  Branches    39980    39980              
==========================================
+ Hits        30107    30108       +1     
- Misses      69816    69824       +8     
+ Partials     2866     2865       -1     
Flag Coverage Δ *Carryforward flag
differential 14.54% <0.00%> (?)
total 29.29% <ø> (+<0.01%) ⬆️ Carriedforward from 4f216b3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit e0002f3 into autowarefoundation:main Nov 13, 2024
32 checks passed
@maxime-clem maxime-clem deleted the fix/costmap_generator-lidar_height_thres branch November 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants