-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Scope Wiring #800
base: master
Are you sure you want to change the base?
Multi-Scope Wiring #800
Conversation
Looks great! Checking it out locally I can make it work with But yeah that solves the ordering problem nicely :) |
Thanks heaps @SentryMan! Did you want me to leave those other two PRs up? |
blackbox-multi-scope/src/main/java/org/multi/scope/CrossCutScope.java
Outdated
Show resolved
Hide resolved
|
||
class BeanCrossTest { | ||
|
||
@Test | ||
void bootstrap() { | ||
private static Stream<Arguments> allModulesDefined() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO these tests are not what we ergonomically desire/need.
That is, we want to say "Give me all the modules that I need for CrossCutModule [and ideally give them in the correct order]" ... and use those to create a BeanScope.
These tests are more just ... we can order the given list of modules correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are more just ... we can order the given list of modules correctly.
do we have an existing test for that?
fd70a80
to
7e271d8
Compare
Now you need only the requires property |
Looks awesome - thank you so much! |
@cbarlin would this suffice?
With this, you would have to add the
requires
property in your@InjectModule
annotations to control the order.AvajeModule
sallRequiredModules
static method if the module has no external project scope dependencies and no transitive constructor paramsResolves #793