Update robotiq_2f_85 to fix removed members.#275
Open
srimanachanta wants to merge 1 commit intoclearpathrobotics:jazzyfrom
Open
Update robotiq_2f_85 to fix removed members.#275srimanachanta wants to merge 1 commit intoclearpathrobotics:jazzyfrom
srimanachanta wants to merge 1 commit intoclearpathrobotics:jazzyfrom
Conversation
`fake_sensor_commands` has been renamed to `mock_sensor_commands` and sim_isaac no longer exists and instead has has been replaced by sim_gazebo. See source here: https://github.com/Kinovarobotics/ros2_kortex/blob/b86f223249da004f6ef863c788ed4fce7157be24/kortex_description/grippers/robotiq_2f_85/urdf/robotiq_2f_85_macro.xacro
srimanachanta
requested review from
roni-kreinin and
tonybaltovski
and removed request for
a team
tonybaltovski
approved these changes
Oct 24, 2025
Member
|
Thanks for catching this! |
🧪 CI InsightsHere's what we observed from your CI run for f0b3a94. 🟢 All jobs passed!But CI Insights is watching 👀 |
tonybaltovski
requested changes
Oct 28, 2025
Member
tonybaltovski
left a comment
tonybaltovski
left a comment
There was a problem hiding this comment.
Looks like the CI failed for mock_components, can you update to pass the CI?
Author
I don't see that CI result (ctrl f for |
Author
|
Can you force the action run for this again so I can look at the logs again. They have expired. |
Member
|
Done @srimanachanta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fake_sensor_commandshas been renamed tomock_sensor_commandsand sim_isaac no longer exists and instead has has been replaced by sim_gazebo. See source here: https://github.com/Kinovarobotics/ros2_kortex/blob/b86f223249da004f6ef863c788ed4fce7157be24/kortex_description/grippers/robotiq_2f_85/urdf/robotiq_2f_85_macro.xacroI'm not sure if we want to rename the arg name as i'm not sure how much of an update that would be across the Clearpath packages. This fixes the immediate build issues.
See:
PickNikRobotics/ros2_robotiq_gripper#61
Kinovarobotics/ros2_kortex@1f873bb