Skip to content

Some Role Authority Cleanup - #13032

Open
Drulikar wants to merge 7 commits into
cmss13-devs:masterfrom
Drulikar:role_authority_cleanup
Open

Some Role Authority Cleanup#13032
Drulikar wants to merge 7 commits into
cmss13-devs:masterfrom
Drulikar:role_authority_cleanup

Conversation

@Drulikar

@Drulikar Drulikar commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

About the pull request

This PR does a few things:

  • Doesn't allow unlimited xenos to be pre-slotted for initial dry-run of round start slotting
  • Changes some of the logic for medic/comtech squad limits (mostly timing different and it no longer relies on unused config settings)
  • Moves some XvX specific logic/variables to that gamemode (rather than on base)
  • Disables most lobby menu buttons when the game is starting

Explain why it's good for the game

  • Should make the dry-run of role authority more accurate so namely xeno slots can be more accurate
  • Should reduce confusion while the game is loading
  • Should reduce confusion in game mode code removing effectively dead code
  • Closes Roundstart psychs you out #13008

Testing Photographs and Procedure

Screenshots & Videos

Readied as just a comtech
lobby
lobby2

Changelog

🆑 Drathek
balance: Initial slot calculation no longer allows infinite xeno slots to be more accurate to the actual slotting afterwards
balance: Technically squad medic and engineer limit calculations have changed, but should ultimately be the same
code: Removed/Moved some XvX code to specifically XvX files
config: Removed two unnecessary configs xeno_number_divider and surv_number_divider
ui: Some lobby menu buttons are now disabled while the game is starting
/:cl:

@Drulikar Drulikar added the Needs Testing Need to test it on the guinea pigs (production server) label Aug 26, 2026
@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Aug 26, 2026
@cmss13-ci cmss13-ci Bot added UI deletes nanoui/html Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Config drag and drop size/L Denotes a PR that changes 200-799 lines, ignoring generated files. labels Aug 26, 2026
@cm13-github

cm13-github commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Test merge deployment history:

Test Merge Deployed @ 08/29/2026 07:35:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 7d3e722
Pull Request: e0b6b53
Server: 4ae4556

Test Merge Updated @ 08/29/2026 12:02:42 +00:00:
Server Instance

CM13 Live

Revision

Origin: 89fbf14
Pull Request: e0b6b53
Server: 87a72b1

Test Merge Updated @ 08/29/2026 15:14:44 +00:00:
Server Instance

CM13 Live

Revision

Origin: 89fbf14
Pull Request: e0b6b53
Server: 31da47f

Test Merge Updated @ 08/29/2026 16:01:51 +00:00:
Server Instance

CM13 Live

Revision

Origin: 407574d
Pull Request: e0b6b53
Server: ddc8aee0fc51131ebc595c8599de85adab6bfbcb

Test Merge Updated @ 08/29/2026 19:02:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 407574d
Pull Request: e0b6b53
Server: 8c1676d

Test Merge Updated @ 08/29/2026 22:34:01 +00:00:
Server Instance

CM13 Live

Revision

Origin: 407574d
Pull Request: e0b6b53
Server: 48b2cee

Test Merge Updated @ 08/30/2026 04:36:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: aadc18b
Pull Request: e0b6b53
Server: 8e94f7a3a5bcfbe07e7220dc6bbee98a076fd780

Test Merge Updated @ 08/30/2026 08:07:48 +00:00:
Server Instance

CM13 Live

Revision

Origin: aadc18b
Pull Request: e0b6b53
Server: 940d7d8

Test Merge Updated @ 08/30/2026 08:38:40 +00:00:
Server Instance

CM13 Live

Revision

Origin: e38bed0
Pull Request: e0b6b53
Server: c1815777d1e9fd7a3cbaf16b6d75e9c7932a2a6a

Test Merge Updated @ 08/30/2026 10:39:52 +00:00:
Server Instance

CM13 Live

Revision

Origin: e38bed0
Pull Request: e0b6b53
Server: 34077b0

Test Merge Updated @ 08/30/2026 11:54:14 +00:00:
Server Instance

CM13 Live

Revision

Origin: e38bed0
Pull Request: e0b6b53
Server: 3e015f1

Test Merge Updated @ 08/30/2026 16:22:23 +00:00:
Server Instance

CM13 Live

Revision

Origin: e38bed0
Pull Request: e0b6b53
Server: 0ef67b6

Test Merge Updated @ 08/31/2026 02:14:25 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6bc71d6
Pull Request: e0b6b53
Server: 056666907d33109d4356a657e75ca47aefce21f5

Test Merge Updated @ 08/31/2026 04:15:42 +00:00:
Server Instance

CM13 Live

Revision

Origin: 2ecc25f
Pull Request: e0b6b53
Server: 44b1cba7eb55734d1ce18837a6e82d37ed0d2069

Test Merge Updated @ 08/31/2026 04:25:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: 2ecc25f
Pull Request: e0b6b53
Server: 896ea40

Test Merge Updated @ 08/31/2026 04:46:33 +00:00:
Server Instance

CM13 Live

Revision

Origin: b004c65
Pull Request: e0b6b53
Server: 2542b25360c45eaead169314848c6f986765c325

Test Merge Updated @ 08/31/2026 05:54:24 +00:00:
Server Instance

CM13 Live

Revision

Origin: b004c65
Pull Request: e0b6b53
Server: 620d162

Test Merge Updated @ 09/01/2026 22:01:17 +00:00:
Server Instance

CM13 Live

Revision

Origin: 313de72
Pull Request: e0b6b53
Server: 6422b5d

Test Merge Updated @ 09/02/2026 02:33:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 47354be
Pull Request: e0b6b53
Server: 12041743c5ebe664b582e3fdd53340c1c346ef81

Test Merge Updated @ 09/02/2026 04:04:18 +00:00:
Server Instance

CM13 Live

Revision

Origin: c12d521
Pull Request: e0b6b53
Server: 87b019f84ce11b693b9dd6ad331987cdab27dc3e

Test Merge Updated @ 09/02/2026 07:05:37 +00:00:
Server Instance

CM13 Live

Revision

Origin: f74475d
Pull Request: e0b6b53
Server: d0d79e90154b54edeaa9b46a9b617a3f6605276c

Test Merge Updated @ 09/02/2026 08:06:33 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9d0564e
Pull Request: e0b6b53
Server: d5e7e0651cee8f6ffbf63f9db2606d3428726179

Test Merge Updated @ 09/02/2026 20:40:02 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9d0564e
Pull Request: e0b6b53
Server: 6be6a07

Test Merge Updated @ 09/02/2026 21:10:56 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1ab3353
Pull Request: e0b6b53
Server: 20b6886328d909633b50246644626a4ca75cc7ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Config drag and drop size/L Denotes a PR that changes 200-799 lines, ignoring generated files. UI deletes nanoui/html

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

Roundstart psychs you out

2 participants