Fix incorrect path references in README and notebooks #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the correct folder path for position_benchmark notebook, added path to openpilot folder for raw_readers notebook. Now, all three notebooks handle PYTHONPATH the same way as the processed_readers notebook originally does, and theres no need for manually adding paths to utilities to PYTHONPATH with export command. Updated README to reflect this change.
Contributor
Author
|
Looks like the github workflow test failed because python 3.7 is at end of life. I will close this pull request, perhaps update the workflow with python 3.8, and combine these two issues into a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some paths in example notebooks and the README have been incorrect since this commit that restructures util folders: f304c57
Solution
This PR updates:
Testing
I believe all three notebooks can run correctly now, without much intervention.
Additional Notes
No functional code was changed, only example notebooks and the README.
This is my first time trying to contribute to open source code, so please, if an mistake is made, point me to the right direction and I'll learn from it, thank you!