Refactor car tests to pytest and fix UI scroller logic #36985
+87
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mici raylib UI Preview✅ Videos are identical! View Diff Report |
Contributor
raylib UI PreviewAll Screenshots
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
Contributor
|
Make sure to not do too many things. This PR addresses two completely different topics at once, you should split one out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: Migrated
test_models.py
and porting tools from unittest to pytest to align with project standards and resolve TID251 (banned-import) lint violations. Replaced setUpClass with scoped fixtures and legacy assertions with native assert.
UI: Refactored Scroller.scroll_to to use absolute offsets instead of relative deltas, resolving a FIXME regarding padding correction. Updated
MiciMainLayout
and
Dialog
callers to match the new API.
Verification:
Verified tests pass via pytest.
Confirmed UI layout transitions remain smooth and correctly positioned.