Automated Integration Test Goldens Update from CI#6106
Conversation
…34a-ba13-15d515d3c0a2)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to golden files, reflecting changes in the system's ability to process and display data for various queries. It includes a general simplification of debug information and chart configurations for certain biological and genetic queries, indicating a shift towards more explicit failure handling when entities are not found. Conversely, a specific health-related query's chart configuration was greatly enhanced to provide a comprehensive view of multiple health metrics across California. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several golden test data files, reflecting changes in the system's behavior regarding entity detection, query resolution, and chart configuration. Notably, some debug_info.json files show a shift from specific entity detections to empty arrays and a new llm_response field, indicating updates in how queries are processed. Several chart_config.json files now include a generic 'failure' message when entities are not found, streamlining error handling. Additionally, there's a significant enhancement in the tellmeaboutheartdisease configuration, moving from a simple entity overview to a comprehensive display of statistical data across various health conditions, including line charts, maps, and ranking tiles. These changes appear to be automated updates to align test expectations with new or refined system logic.
ajaits
left a comment
There was a problem hiding this comment.
All changes are related to removal of biomed entities.
| { | ||
| "quantity": { | ||
| "idx": 0, | ||
| "qval": { | ||
| "cmp": "GE", | ||
| "val": 2.2250738585072014e-308 | ||
| } | ||
| }, | ||
| "type": 3 | ||
| }, |
There was a problem hiding this comment.
@shixiao-coder is this the change you said should be reverted? I'm a little confused because the value is effectively 0 anyway.
There was a problem hiding this comment.
yes, we can revert this. I believe the diff is text diff instead of value diff and causing this to show up in the failure
| def test_detection_bio(self): | ||
| self.run_detection('detection_api_bio', [ | ||
| 'What is the phylum of volvox?', | ||
| 'What types of genes are FGFR1, APOE, and ACHE?', | ||
| ], | ||
| dc='bio', | ||
| check_detection=True) | ||
|
|
There was a problem hiding this comment.
@shixiao-coder In order to get NL tests to pass, I'm seeing I need to remove this test -- we've removed the bio BT tables, so I think this is the right change to make.
14f3174 to
3da27b7
Compare
This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log