Skip to content

Automated Integration Test Goldens Update from CI#6106

Merged
juliawu merged 4 commits intomasterfrom
nl-golden-update-7e53d964-9be8-434a-ba13-15d515d3c0a2
Mar 20, 2026
Merged

Automated Integration Test Goldens Update from CI#6106
juliawu merged 4 commits intomasterfrom
nl-golden-update-7e53d964-9be8-434a-ba13-15d515d3c0a2

Conversation

@datacommons-robot-author
Copy link
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and dwnoble and removed request for a team March 19, 2026 18:20
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains automated updates to golden files, reflecting changes in the system's ability to process and display data for various queries. It includes a general simplification of debug information and chart configurations for certain biological and genetic queries, indicating a shift towards more explicit failure handling when entities are not found. Conversely, a specific health-related query's chart configuration was greatly enhanced to provide a comprehensive view of multiple health metrics across California.

Highlights

  • Debug Info Updates: The debug_info.json files for biological entity detection queries (whatisthephylumofvolvox and whattypesofgenesarefgfr1,apoe,andache) were updated to clear previously detected and resolved entities, as well as SV and property matching scores. This indicates a change in how these queries are processed or how their debug output is structured.
  • Chart Configuration Simplification: Several chart_config.json files (howaboutforpqlc3, whatgenesareassociatedwiththegeneticvariantrs13317, whatgenesareassociatedwiththegeneticvariantrs13317andrs7903146, whatgenomiccoordinatesdoesithave, whatisbetacoronavirus1thespeciesof) were significantly simplified. They now primarily indicate a 'failure' to find entities and have removed extensive configuration details, entities, and related things data.
  • Expanded Health Chart Configuration: The tellmeaboutheartdisease/chart_config.json file was substantially expanded. It now includes detailed chart configurations for various health conditions in California, such as Coronary Heart Disease, Chronic Obstructive Pulmonary Disease, Stroke, and Physical Health Issues, complete with line charts, maps, and ranking tiles.
  • Minor Chart Configuration Adjustments: Minor adjustments were made to other chart configurations, including the removal of an outdated quantity classification in stateswithhighestphds and the addition of 'Economic Activity' to peer topics in povertyvs.unemploymentrateindistrictsoftamilnadu. The howhasthegdpgrown chart configuration also saw a swap in the display order of Rwanda and Ethiopia.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several golden test data files, reflecting changes in the system's behavior regarding entity detection, query resolution, and chart configuration. Notably, some debug_info.json files show a shift from specific entity detections to empty arrays and a new llm_response field, indicating updates in how queries are processed. Several chart_config.json files now include a generic 'failure' message when entities are not found, streamlining error handling. Additionally, there's a significant enhancement in the tellmeaboutheartdisease configuration, moving from a simple entity overview to a comprehensive display of statistical data across various health conditions, including line charts, maps, and ranking tiles. These changes appear to be automated updates to align test expectations with new or refined system logic.

@juliawu juliawu requested review from ajaits and shixiao-coder March 20, 2026 03:17
Copy link
Contributor

@ajaits ajaits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are related to removal of biomed entities.

Comment on lines -4 to -13
{
"quantity": {
"idx": 0,
"qval": {
"cmp": "GE",
"val": 2.2250738585072014e-308
}
},
"type": 3
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shixiao-coder is this the change you said should be reverted? I'm a little confused because the value is effectively 0 anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we can revert this. I believe the diff is text diff instead of value diff and causing this to show up in the failure

Comment on lines -324 to -331
def test_detection_bio(self):
self.run_detection('detection_api_bio', [
'What is the phylum of volvox?',
'What types of genes are FGFR1, APOE, and ACHE?',
],
dc='bio',
check_detection=True)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shixiao-coder In order to get NL tests to pass, I'm seeing I need to remove this test -- we've removed the bio BT tables, so I think this is the right change to make.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, agreed

@juliawu juliawu force-pushed the nl-golden-update-7e53d964-9be8-434a-ba13-15d515d3c0a2 branch from 14f3174 to 3da27b7 Compare March 20, 2026 18:09
@juliawu juliawu enabled auto-merge (squash) March 20, 2026 18:12
@juliawu juliawu merged commit 2f24bc9 into master Mar 20, 2026
12 checks passed
@juliawu juliawu deleted the nl-golden-update-7e53d964-9be8-434a-ba13-15d515d3c0a2 branch March 20, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants