-
Notifications
You must be signed in to change notification settings - Fork 122
Automated Integration Test Goldens Update from CI #6106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliawu
merged 4 commits into
master
from
nl-golden-update-7e53d964-9be8-434a-ba13-15d515d3c0a2
Mar 20, 2026
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cef350a
feat: Update goldens from Cloud Build workflow (build 7e53d964-9be8-4…
datacommons-robot-author 7e90631
Merge branch 'master' into nl-golden-update-7e53d964-9be8-434a-ba13-1…
juliawu 14f3174
remove test_detection_bio
juliawu 3da27b7
Revert stateswithhighestphds change
juliawu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,374 changes: 11 additions & 1,363 deletions
1,374
...n_tests/test_data/detection_api_bio/whattypesofgenesarefgfr1,apoe,andache/debug_info.json
Large diffs are not rendered by default.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
...integration_tests/test_data/detection_api_context/stateswithhighestphds/chart_config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 7 additions & 60 deletions
67
server/integration_tests/test_data/e2e_triple/howaboutforpqlc3/chart_config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,68 +1,15 @@ | ||
| { | ||
| "client": "test_detect-and-fulfill", | ||
| "config": { | ||
| "categories": [ | ||
| { | ||
| "blocks": [ | ||
| { | ||
| "columns": [ | ||
| { | ||
| "tiles": [ | ||
| { | ||
| "answerTableTileSpec": { | ||
| "columns": [ | ||
| { | ||
| "header": "Has Genomic Coordinates", | ||
| "propertyExpr": "->hasGenomicCoordinates" | ||
| } | ||
| ] | ||
| }, | ||
| "entities": [ | ||
| "bio/ncbi_109457387", | ||
| "bio/ncbi_421941" | ||
| ], | ||
| "title": "The Has Genomic Coordinates for PQLC3 are as follows:", | ||
| "type": "ANSWER_TABLE" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| "config": {}, | ||
| "context": {}, | ||
| "debug": {}, | ||
| "entities": [ | ||
| { | ||
| "dcid": "bio/ncbi_109457387", | ||
| "name": "PQLC3", | ||
| "type": "" | ||
| }, | ||
| { | ||
| "dcid": "bio/ncbi_421941", | ||
| "name": "PQLC3", | ||
| "type": "" | ||
| } | ||
| ], | ||
| "pastSourceContext": "", | ||
| "place": {}, | ||
| "placeFallback": {}, | ||
| "placeSource": "UNKNOWN", | ||
| "places": [], | ||
| "relatedThings": { | ||
| "childPlaces": {}, | ||
| "childTopics": [], | ||
| "exploreMore": {}, | ||
| "mainTopics": [], | ||
| "parentPlaces": [], | ||
| "parentTopics": [], | ||
| "peerPlaces": [], | ||
| "peerTopics": [] | ||
| "failure": "Sorry, could not complete your request. No entity found in the query.", | ||
| "place": { | ||
| "dcid": "", | ||
| "name": "", | ||
| "place_type": "" | ||
| }, | ||
| "svSource": "UNKNOWN", | ||
| "userMessages": [ | ||
| "See relevant information based on the previous query." | ||
| "Sorry, could not complete your request. No entity found in the query." | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shixiao-coder is this the change you said should be reverted? I'm a little confused because the value is effectively 0 anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we can revert this. I believe the diff is text diff instead of value diff and causing this to show up in the failure