-
Notifications
You must be signed in to change notification settings - Fork 2
chore(docs): update manual about VM traffic redirect #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ruslan Usmanov <[email protected]>
Signed-off-by: Ruslan Usmanov <[email protected]>
Reviewer's GuideUpdated VM traffic redirect documentation in English and Russian to clearly explain using the Kubernetes Service resource with selectors, improved the VM and Service examples by adding namespacing and multi-port LoadBalancer configuration, and removed the outdated dynamic service example. Class diagram for updated VM and Service resource examplesclassDiagram
class VirtualMachine {
apiVersion: virtualization.deckhouse.io/v1alpha2
kind: VirtualMachine
metadata:
name: frontend-0
namespace: dev
labels:
vm: frontend-0
spec: ...
}
class Service {
apiVersion: v1
kind: Service
metadata:
name: web-svc
namespace: dev
spec:
type: LoadBalancer
ports:
ssh: 2211 -> 22
http: 80 -> 80
https: 443 -> 443
selector:
vm: frontend-0
}
Service "1" --> "1" VirtualMachine
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The numbered list steps all use “1.”; consider renumbering to 1, 2, 3 for clarity and consistency.
- It may help to briefly note which Service types (ClusterIP, NodePort, LoadBalancer) are supported and when to use each for VM traffic routing.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The numbered list steps all use “1.”; consider renumbering to 1, 2, 3 for clarity and consistency.
- It may help to briefly note which Service types (ClusterIP, NodePort, LoadBalancer) are supported and when to use each for VM traffic routing.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Ruslan Usmanov <[email protected]>
Co-authored-by: Vladislav Panfilov <[email protected]> Signed-off-by: Ruslan Usmanov <[email protected]>
Description
Update manual about VM traffic redirect
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries